Skip to content

Conversation

yadaiio
Copy link
Contributor

@yadaiio yadaiio commented Nov 8, 2023

This pull request fixes a few typos with the help of https://github.com/szepeviktor/typos-on-you.

Builds on top of #27 and #18.

@yadaiio
Copy link
Contributor Author

yadaiio commented Nov 9, 2023

Additionally, I took a closer look at the examples/users.ndjson file as @clue suggested in the comment clue/reactphp-flux#28 (comment). I noticed that the two files are not identical, so there was no 'nineth' to fix here. Thank you for the helping hand in sharpening my eye for something like this. 🧐 There are a few projects which are kind of similiar in their structure but in their own way unique. 🤩

@SimonFrings SimonFrings added the documentation Improvements or additions to documentation label Nov 9, 2023
Copy link
Contributor

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@clue clue added this to the v1.4.0 milestone Nov 9, 2023
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yadaiio Thank you for looking into this, changes LGTM! :shipit:

@clue clue merged commit 9453d1a into clue:1.x Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants