Skip to content

Conversation

PaulRotmann
Copy link
Contributor

@PaulRotmann PaulRotmann commented Jul 2, 2025

Update dependencies to support PHP 5.3 and react/promise v3.2+

  • Upgrade react/promise dependency to include v3.2+, adapting to new resolve() API that requires an argument.
  • Update clue/multicast-react:
    • The latest code includes essential fixes for compatibility with updated react/promise APIs and PHP 8+,
    • This ensures multicast functionality works correctly with new dependencies and PHP versions.
  • Modify search() method to accumulate all incoming messages in array() before resolving the promise, ensuring proper integration with the updated promise API and maintaining PHP 5.3 compatibility.
  • Use explicit array() syntax instead of [] throughout the code for PHP 5.3 support.

Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PaulRotmann Thanks for looking into this, but I don't quite understand how this is related to #18 and #19 and why this builds on to top of these changes. I think this could be simplified by avoiding this dependency to ease review. Can you look into this to help isolate/emphasize what is being "improved" here exactly?

@PaulRotmann
Copy link
Contributor Author

@clue you're right, this PR can stand alone. Changed the original text to and commit to explain better

@PaulRotmann
Copy link
Contributor Author

After conversation with @clue i noticed this PR will be too hard for me to handle, because of promise v3.
I'll close this PR for now, but this topic should be addressed in future.

@PaulRotmann PaulRotmann closed this Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants