fix: add explicit support for 'now' keyword#29
Merged
Conversation
Previously 'now' worked by accident (falling through to return moment()). Now it explicitly handles 'now' and preserves the moment's context. - Add explicit 'now' check in relativeTime() before regex matching - Returns moment(this) to preserve the original moment's time - Add test to verify context preservation with specific dates 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
cmaurer
changed the title
- Add PR trigger (previously only ran on push) - Change publish trigger from master push to version tags (refs/tags/v*) - Add npm caching for faster builds - Add timeout-minutes (10) to prevent hanging jobs - Add fail-fast: false to run all Node versions even if one fails - Add consistent step names for better readability 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Change 'npm test' to 'npm run coverage' to generate LCOV files - Add parallel flag for matrix builds - Add coveralls-finish job to complete parallel build reporting 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Provides project overview, key commands, architecture details, testing info, code conventions, and common pitfalls for Claude Code. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously 'now' worked by accident (falling through to return moment()). Now it explicitly handles 'now' and preserves the moment's context.