fix: enable altering hypertable dimensions via AlterHypertableOperation #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes issue #14 where changes to hypertable dimensions were not being detected or applied during migrations. Changes: - Add AdditionalDimensions and OldAdditionalDimensions properties to AlterHypertableOperation - Implement dimension comparison logic in HypertableDiffer.AreDimensionsEqual() - Update HypertableOperationGenerator to generate add_dimension() SQL for new dimensions - Add warning comment when dimensions are removed (TimescaleDB limitation) - Fix minor whitespace formatting issues in test files Technical details: - Only new dimensions generate SQL in Up() migrations - Removed dimensions generate warning comments in Down() migrations (cannot be reversed) - Dimension comparison checks ColumnName, Type, Interval, and NumberOfPartitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes issue #14 where changes to hypertable dimensions were not being detected or applied during migrations.
Changes:
Technical details: