Add new image and CMSSW version to CI workflow#1211
Conversation
📝 WalkthroughWalkthroughThis PR adds a single new matrix include entry to the CVMFS CI workflow Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @.github/workflows/cvmfs-ci.yml:
- Around line 37-40: Update the CI matrix entry to match CMSSW_16_0_0's official
build by changing SCRAM_ARCH to "el8_amd64_gcc13" and ROOT to "6.36.05" for the
CMSSW_16_0_0 matrix row (referencing SCRAM_ARCH, ROOT, CMSSW_VERSION in the
YAML); also review the conditional that gates the RooMultiPdf and RooHistPdf
steps which currently use startsWith(matrix.CMSSW_VERSION, 'CMSSW_14')
(referencing RooMultiPdf, RooHistPdf and the startsWith expression) and either
broaden it to include CMSSW_16 (e.g., check for 'CMSSW_14' OR 'CMSSW_16') if
those tests should run on 16, or document/confirm the intentional exclusion and
leave it unchanged.
| - IMAGE: "cmscloud/al9-cms" | ||
| CMSSW_VERSION: "CMSSW_16_0_0" | ||
| SCRAM_ARCH: "el9_amd64_gcc12" | ||
| ROOT: "6.36.07" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# Check lines 197 and 212 for the startsWith conditions
rg -n 'startsWith.*CMSSW_VERSION' .github/workflows/cvmfs-ci.yml -A 2 -B 2Repository: cms-analysis/HiggsAnalysis-CombinedLimit
Length of output: 513
🌐 Web query:
CMSSW_16_0_0 release CVMFS availability
💡 Result:
- CMSSW_16_0_0 is an official CMSSW release with release date Jan 30, 2026. [1]
- The release notes indicate it is built for
el8_amd64_gcc13(via the cmsdist tagREL/CMSSW_16_0_0/el8_amd64_gcc13), which is the architecture you should expect on CVMFS. [2] - To check CVMFS availability at your site, do:
(
source /cvmfs/cms.cern.ch/cmsset_default.sh scram list CMSSW | grep CMSSW_16_0_0
scram list CMSSWlists the releases available via your environment/CVMFS.) [3][4]
Sources: [1] CMSSW_16_0_0 release notes (cmssdt.cern.ch) (cmssdt.cern.ch), [2] CMSSW_16_0_0_patch1 notes showing REL/CMSSW_16_0_0/el8_amd64_gcc13 (cmssdt.cern.ch) (cmssdt.cern.ch), [3] USCMS software setup (cmsset_default.sh) (uscms.org), [4] CodiMD tutorial mentioning scram list CMSSW (codimd.web.cern.ch)
Citations:
- 1: https://cmssdt.cern.ch/SDT/ReleaseNotes/CMSSW_16/CMSSW_16_0_0.html
- 2: https://cmssdt.cern.ch/SDT/ReleaseNotes/CMSSW_16/CMSSW_16_0_0_patch1.html
- 3: https://uscms.org/uscms_at_work/computing/setup/setup_software.shtml?utm_source=openai
- 4: https://codimd.web.cern.ch/s/glLKn0Nb-?utm_source=openai
🌐 Web query:
CMSSW_16_0_0 ROOT version bundled
💡 Result:
CMSSW_16_0_0 is built against ROOT 6.36, specifically ROOT 6.36.05 (from the v6-36-00-patches line). [1]
Source: the CMSSW release notes explicitly list the CMSDIST change “Update root version to 6.36.05” for the CMSSW_16_0_0 series. [1]
References
[1] cms-sw/cmssw GitHub releases (CMSSW_16_0_0_pre2_RNTUPLE notes showing ROOT update to 6.36.05) https://github.com/cms-sw/cmssw/releases
Correct the SCRAM_ARCH and ROOT version for CMSSW_16_0_0.
The matrix entry specifies SCRAM_ARCH: "el9_amd64_gcc12" and ROOT: "6.36.07", but CMSSW_16_0_0 is officially built for el8_amd64_gcc13 and bundles ROOT 6.36.05. Update to match the official release configuration.
Additionally, the RooMultiPdf and RooHistPdf test steps (lines 197 and 212) use the condition startsWith(matrix.CMSSW_VERSION, 'CMSSW_14'), which will exclude CMSSW_16_0_0. Verify this exclusion is intentional; if these tests should run with CMSSW 16, broaden the condition to include it.
🤖 Prompt for AI Agents
In @.github/workflows/cvmfs-ci.yml around lines 37 - 40, Update the CI matrix
entry to match CMSSW_16_0_0's official build by changing SCRAM_ARCH to
"el8_amd64_gcc13" and ROOT to "6.36.05" for the CMSSW_16_0_0 matrix row
(referencing SCRAM_ARCH, ROOT, CMSSW_VERSION in the YAML); also review the
conditional that gates the RooMultiPdf and RooHistPdf steps which currently use
startsWith(matrix.CMSSW_VERSION, 'CMSSW_14') (referencing RooMultiPdf,
RooHistPdf and the startsWith expression) and either broaden it to include
CMSSW_16 (e.g., check for 'CMSSW_14' OR 'CMSSW_16') if those tests should run on
16, or document/confirm the intentional exclusion and leave it unchanged.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1211 +/- ##
=======================================
Coverage 20.71% 20.71%
=======================================
Files 195 195
Lines 26166 26166
Branches 3924 3924
=======================================
Hits 5420 5420
Misses 20746 20746 🚀 New features to boost your workflow:
|
1 participant
Summary by CodeRabbit