Skip to content

Conversation

@makortel
Copy link
Contributor

@makortel makortel commented Aug 28, 2025

This PR provides new test files needed for cms-sw/cmssw#48817

Resolves cms-sw/framework-team#1451

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel for branch master.

@Dr15Jones, @akritkbehera, @cmsbuild, @iarspider, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 28, 2025

cms-bot internal usage

@makortel
Copy link
Contributor Author

makortel commented Dec 3, 2025

+core

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2025

REMINDER @sextonkennedy, @ftenchini, @mandrenguyen: This PR was tested with cms-sw/cmssw#48817, please check if they should be merged together

@makortel
Copy link
Contributor Author

makortel commented Dec 3, 2025

This was tested together with cms-sw/cmssw#48817, and needs to be merged with it. Do we need to repeat the tests on this side too?

@ftenchini
Copy link

+1

@ftenchini
Copy link

Sorry, i merged both the test PR and this, but I didn't notice some flags were still yellow here.

@ftenchini
Copy link

ftenchini commented Dec 4, 2025

I suppose it's missing externals approval only, no need to test again if it's been tested in the other PR already.

@mandrenguyen
Copy link

merge
Indeed if it's tested in the cmssw PR, no need to test it again here.

@cmsbuild cmsbuild merged commit 7a31542 into cms-data:master Dec 4, 2025
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Try out the auto_ptr rules in ROOT 6.36

4 participants