Add Github action to automatically diff new schema against old schema with updater applied

.gh_action_data/run-schemadiff.sh

@@ -0,0 +1,26 @@
+#!/usr/bin/env bash
+
+# Create SQL dump of the old schema (with updates applied)
+dropdb --host=testdb --username=postgres cmsdbfortesting
+createdb --host=testdb --username=postgres cmsdbfortesting
+psql --host=testdb --username=postgres cmsdbfortesting < .gh_action_data/1.5.sql
+psql --host=testdb --username=postgres cmsdbfortesting < cmscontrib/updaters/update_from_1.5.sql
+pg_dump --host=testdb --username=postgres --schema-only cmsdbfortesting > .gh_action_data/updated_schema.sql
+
+# Create SQL dump of the new schema
+dropdb --host=testdb --username=postgres cmsdbfortesting
+createdb --host=testdb --username=postgres cmsdbfortesting
+cmsInitDB
+pg_dump --host=testdb --username=postgres --schema-only cmsdbfortesting > .gh_action_data/new_schema.sql
+
+# Compare the two schema dumps
+diff .gh_action_data/updated_schema.sql .gh_action_data/new_schema.sql | grep -v '^--' | grep -v -e '^[[:space:]]*$' > .gh_action_data/schema_diff.txt
+if [ -s .gh_action_data/schema_diff.txt ]
+then
+    echo "Schema diff found:"
+    cat .gh_action_data/schema_diff.txt
+    exit 1
+else
+    echo "No schema diff found."
+    exit 0
+fi

.github/CODEOWNERS

@@ -1,2 +0,0 @@
-# For things like schema changes, where we need to make sure that an updater is provided
-/cms/db     @wil93

.github/workflows/main.yml

@@ -1,4 +1,4 @@
-name: ci
+name: Run unit and functional tests
 
 on:
   - push

.github/workflows/schema_diff.yml

@@ -0,0 +1,22 @@
+name: Check DB schema differences
+
+on:
+  - push
+  - pull_request
+
+jobs:
+  test:
+    runs-on: ubuntu-22.04
+
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          submodules: true
+
+      - name: Build docker image
+        run: |
+          docker compose -p cms -f docker-compose.test.yml build testcms
+
+      - name: Check schema diff
+        run: |
+          docker compose -p cms -f docker-compose.test.yml run --rm schemadiff

docker-compose.test.yml

@@ -18,7 +18,7 @@ services:
       - "./codecov:/home/cmsuser/cms/codecov"
     privileged: true
     cgroup: host
-    command: wait-for-it testdb:5432 -- ./_cms-test-internal.sh
+    command: wait-for-it testdb:5432 -- .gh_action_data/run-test.sh
 
   stresstestcms:
     build: .
@@ -28,4 +28,14 @@ services:
       CMS_CONFIG: /usr/local/etc/cms-testdb.toml
     privileged: true
     cgroup: host
-    command: wait-for-it testdb:5432 -- ./_cms-stresstest-internal.sh
+    command: wait-for-it testdb:5432 -- .gh_action_data/run-stresstest.sh
+
+  schemadiff:
+    build: .
+    depends_on:
+      - "testdb"
+    environment:
+      CMS_CONFIG: /usr/local/etc/cms-testdb.toml
+    privileged: true
+    cgroup: host
+    command: wait-for-it testdb:5432 -- .gh_action_data/run-schemadiff.sh