Add SQL schema updater checker to test suite #1443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converted it to an unit test instead of a separate testing step. (Initially I was afraid of doing this because it requires dropping and recreating the database multiple times, but then I realized that DatabaseMixin already does this, so implementing this as an unit test doesn't make the unit tests any more destructive than they already are.) Also, here's what the output looks like in case of a mismatch (as an example, commenting out some lines of update_from_v1.5.sql): |
prandla
force-pushed
the
schema-diff
branch
2 times, most recently
from
9a18497 to
4d14e43
Compare
wil93
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1422, but with a completely custom comparator.