Skip to content

Report workflows failing maxmem check as a numericly sorted list #2654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smuzaffar merged 3 commits into from
Jan 17, 2026
Merged

Report workflows failing maxmem check as a numericly sorted list #2654

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ad50c3
Report workflows failing maxmem check as a numericly sorted list
gartung Jan 16, 2026
247bd53
Black formatting
gartung Jan 16, 2026
fd5edc5
Workflow string is s[3] not s[2] because grep output includes filename
gartung Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions report-pull-request-results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,19 +298,25 @@ def read_material_budget_log_file(unit_tests_file):
# reads maxmem comparison error files
#
def read_maxmem_comparison_file(unit_tests_file):
errors_found = ""
errors_found = set()
err_cnt = 0
for line in openlog(unit_tests_file):
if "exceeds" in line.lower():
err_cnt += 1
errors_found += " - " + line.split(":")[1:] + "\n"

message_line = ("-",)
message_line += tuple(line.split(":", 1)[-1].strip().split(" "))
message_line += ("\n",)
errors_found.add(message_line)
if err_cnt > 0:
message = (
"\n## Max Memory Comparisons exceeding threshold\n\n"
"@cms-sw/core-l2 , I found %s workflow step(s) with memory usage exceeding the error threshold:\n\n%s"
% (err_cnt, errors_found)
"@cms-sw/core-l2 , I found %s workflow step(s) with memory usage exceeding the error threshold:\n"
% err_cnt
)
message += "<details>\n<summary>Expand to see workflows ...</summary>\n\n"
for message_line in sorted(errors_found, key=lambda s: float(s[3].split("_")[0])):
message += " ".join(message_line)
message += "</details>\n\n"
send_message_pr(message)


Expand Down