Merge pull request #48051 from BenjaminRS/L1TrackObjectNtupleMaker_SimVertexBugFix

cmsbuild · web-flow · commit 08f930f89af2 · 2025-05-11T17:12:57.000+02:00
[L1T] Fixing a bug where an empty SimVertex collection would crash the L1TrackObjectNtupleMaker (Phase2)
diff --git a/L1Trigger/L1TTrackMatch/test/L1TrackObjectNtupleMaker.cc b/L1Trigger/L1TTrackMatch/test/L1TrackObjectNtupleMaker.cc
@@ -2391,8 +2391,12 @@ void L1TrackObjectNtupleMaker::analyze(const edm::Event& iEvent, const edm::Even
   }
 
   if (SimVertexHandle.isValid()) {
-    const SimVertex simPVh = *(SimVertexHandle->begin());
-    m_pv_MC->push_back(simPVh.position().z());
+    if (!SimVertexHandle->empty()) {
+      const SimVertex simPVh = *(SimVertexHandle->begin());
+      m_pv_MC->push_back(simPVh.position().z());
+    } else {
+      edm::LogWarning("MissingCollectionEntries") << "\nWarning: SimVertex collection is empty!" << std::endl;
+    }
   } else {
     edm::LogWarning("DataNotFound") << "\nWarning: SimVertexHandle not found in the event" << std::endl;
   }

Original file line number	Diff line number	Diff line change
`@@ -2391,8 +2391,12 @@ void L1TrackObjectNtupleMaker::analyze(const edm::Event& iEvent, const edm::Even`
`2391`	`2391`	`}`
`2392`	`2392`
`2393`	`2393`	`if (SimVertexHandle.isValid()) {`
`2394`		`- const SimVertex simPVh = *(SimVertexHandle->begin());`
`2395`		`- m_pv_MC->push_back(simPVh.position().z());`
	`2394`	`+ if (!SimVertexHandle->empty()) {`
	`2395`	`+ const SimVertex simPVh = *(SimVertexHandle->begin());`
	`2396`	`+ m_pv_MC->push_back(simPVh.position().z());`
	`2397`	`+ } else {`
	`2398`	`+ edm::LogWarning("MissingCollectionEntries") << "\nWarning: SimVertex collection is empty!" << std::endl;`
	`2399`	`+ }`
`2396`	`2400`	`} else {`
`2397`	`2401`	`edm::LogWarning("DataNotFound") << "\nWarning: SimVertexHandle not found in the event" << std::endl;`
`2398`	`2402`	`}`