Skip to content

Conversation

@makortel
Copy link
Contributor

@makortel makortel commented Aug 4, 2025

PR description:

These missing dictionaries were found in root-project/root#18402 (comment)

Resolves cms-sw/framework-team#1492

PR validation:

With a developer area created from cms-sw/root#222 (comment) the workflows that failed in the test succeeded with these changes.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2025

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2025

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • DataFormats/L1TrackTrigger (l1, upgrade)

@BenjaminRS, @Moanwar, @cmsbuild, @quinnanm, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@missirol, @mmusich, @rovere, @sviret this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Aug 4, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2025

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f69359/47524/summary.html
COMMIT: bda41cd
CMSSW: CMSSW_15_1_X_2025-08-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/48669/47524/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4076122
  • DQMHistoTests: Total failures: 26
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4076076
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 184 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor Author

makortel commented Aug 5, 2025

Comparison differences are related to #47071 and #48504

@BenjaminRS
Copy link
Contributor

+l1

@makortel
Copy link
Contributor Author

@cms-sw/upgrade-l2 Could you review and sign, please?

@Moanwar
Copy link
Contributor

Moanwar commented Aug 11, 2025

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 57a10f3 into cms-sw:master Aug 12, 2025
10 checks passed
@makortel makortel deleted the addMissingDictionaries branch August 13, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing dictionaries

5 participants