Replacing"TMath.h" usage in favor of CMath

[akritkbehera]

PR description:

Root update cms-sw/cmsdist#10005 failing due to missing #include "TMath.h" in EcalPerEvtLaserAnalyzer.cc

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48716/45757

[cmsbuild]

A new Pull Request was created by @akritkbehera for master.

It involves the following packages:

• CalibCalorimetry/EcalLaserAnalyzer (alca)

@atpathak, @cmsbuild, @perrotta can you please review it and eventually sign? Thanks.
@ReyerBand, @argiro, @mmusich, @rchatter, @rsreds, @thomreis, @tocheng, @wang0jin, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[iarspider]

please test
just in case - test for master IB

[cmsbuild]

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4dec7/47654/summary.html
COMMIT: 590f0a1
CMSSW: CMSSW_15_1_X_2025-08-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48716/47654/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @stahlleiton Add dEdx lfit to PbPb eras #48690

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4dec7/47654/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e4dec7/47654/git-merge-result

Comparison Summary

Summary:

• You potentially removed 5 lines from the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 4076122
• DQMHistoTests: Total failures: 69
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4076033
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 215 log files, 184 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[smuzaffar]

@iarspider , looks like there are few other packages which are failing https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a23b57/47646/build-logs/ , can you update this PR to provide a fix for those too?

[smuzaffar]

@iarspider , looks like root has replaced the use of TMath::(min|Max) with std::(min|max) (root-project/root@9bd7729) , I would suggest to include cmath and replace TMath::* functions with std library

[iarspider]

@smuzaffar did you mean @akritkbehera ? I just triggered the tests. But of course I can do it as well.

[smuzaffar]

oops, yes @akritkbehera

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48716/45759

[kpedro88]

+simulation

[perrotta]

+alca

[rseidita]

+dqm

[Moanwar]

+Upgrade

[smuzaffar]

@alja , can you please again sign it for @cms-sw/visualization-l2 ?

[smuzaffar]

@cms-sw/l1-l2 , can you please review this?

[alja]

+1

[smuzaffar]

@BenjaminRS , @quinnanm can you please review this PR . It just replaces the use of TMath::(Min|Max|Abs) with std::(min|max|abs) . This PR is needed for integrating latest ROOT master changes cms-sw/cmsdist#10005

[BenjaminRS]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1