Need to add TracksHost::Implementation to classes_def.xml #49360

Dr15Jones · 2025-11-10T16:56:35Z

PR description:

This avoids a segmentation fault in new version of ROOT.

PR validation:

Ran with addOn test Raw_PIon_MC_HLT in CMSSW_16_0_ROOT6_X_2025-11-06-2300 and that now works.

resolves #49333
resolves cms-sw/framework-team#1647

cmsbuild · 2025-11-10T16:57:04Z

cms-bot internal usage

cmsbuild · 2025-11-10T16:58:36Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49360/46749

cmsbuild · 2025-11-10T16:59:03Z

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

DataFormats/TrackSoA (heterogeneous, reconstruction)

@cmsbuild, @fwyzard, @jfernan2, @makortel, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@VinInn, @VourMa, @elusian, @gpetruc, @missirol, @mmasciov, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2025-11-10T16:59:26Z

please test

mmusich · 2025-11-10T17:24:07Z

is there a chance that this would also fix #49349 ?

Dr15Jones · 2025-11-10T17:27:24Z

is there a chance that this would also fix #49349 ?

seems unlikely.

makortel · 2025-11-10T17:38:26Z

is there a chance that this would also fix #49349 ?

seems unlikely.

I tested with the setup I had in #49349 (comment) and indeed the valgrind warning was still there with this PR.

mmusich · 2025-11-10T17:42:43Z

I tested with the setup I had in #49349 (comment) and indeed the valgrind warning was still there with this PR.

thanks, I was asking in light of a possible need to backport to 15.1.X for operations.

smuzaffar · 2025-11-10T17:51:32Z

please test for CMSSW_16_0_ROOT636_X/el8_amd64_gcc13

smuzaffar · 2025-11-10T17:55:37Z

please test for CMSSW_16_0_ROOT6_X

smuzaffar · 2025-11-10T18:41:22Z

addOn tests for ROOT6 and ROOT636 passed

cmsbuild · 2025-11-10T19:12:13Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-86bf36/49381/summary.html
COMMIT: 3d3084d
CMSSW: CMSSW_16_0_X_2025-11-10-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49360/49381/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-86bf36/49381/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-86bf36/49381/git-merge-result

Comparison Summary

Summary:

You potentially added 1 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
Reco comparison had 2 failed jobs
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4172318
DQMHistoTests: Total failures: 51
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4172247
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 226 log files, 198 edm output root files, 53 DQM output files
TriggerResults: no differences found

cmsbuild · 2025-11-10T19:54:11Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-86bf36/49385/summary.html
COMMIT: 3d3084d
CMSSW: CMSSW_16_0_ROOT636_X_2025-11-07-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49360/49385/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-86bf36/49385/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-86bf36/49385/git-merge-result

Comparison Summary

Summary:

You potentially added 166 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 53 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4172318
DQMHistoTests: Total failures: 16091
DQMHistoTests: Total nulls: 14
DQMHistoTests: Total successes: 4156193
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 226 log files, 198 edm output root files, 53 DQM output files
TriggerResults: found differences in 4 / 51 workflows

cmsbuild · 2025-11-10T20:06:31Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-86bf36/49387/summary.html
COMMIT: 3d3084d
CMSSW: CMSSW_16_0_ROOT6_X_2025-11-09-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49360/49387/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-86bf36/49387/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-86bf36/49387/git-merge-result

Comparison Summary

Summary:

You potentially added 280 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 47 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4172318
DQMHistoTests: Total failures: 13486
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4158812
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 226 log files, 198 edm output root files, 53 DQM output files
TriggerResults: no differences found

fwyzard · 2025-11-11T16:22:28Z

+heterogeneous

cmsbuild · 2025-11-11T16:23:08Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49360/46764

cmsbuild · 2025-11-11T16:23:28Z

Pull request #49360 was updated. @jfernan2, @mandrenguyen, @srimanob can you please check and sign again.

cmsbuild · 2025-11-11T18:12:03Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-86bf36/49406/summary.html
COMMIT: 4add06b
CMSSW: CMSSW_16_0_X_2025-11-11-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49360/49406/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
Reco comparison had 2 failed jobs
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4172318
DQMHistoTests: Total failures: 47
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4172251
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 226 log files, 198 edm output root files, 53 DQM output files
TriggerResults: no differences found

smuzaffar · 2025-11-11T21:43:27Z

@cms-sw/reconstruction-l2 , can you please review/sign this? This is a workaround to fix the addOn tests in ROOT6/ROOT636 IBs. This will allow us to move forward with ROOT636 integration

smuzaffar · 2025-11-12T08:39:43Z

kind reminder @cms-sw/reconstruction-l2
@cms-sw/core-l2 would like to get this in for 11h00 IB o that we can go ahead with cms-sw/cmsdist#10187 integration (which requires this change)

jfernan2 · 2025-11-12T08:46:57Z

+1

cmsbuild · 2025-11-12T08:47:21Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

smuzaffar · 2025-11-12T08:48:04Z

thanks @jfernan2

@ftenchini, @mandrenguyen, can we get this in for 11h00 IB?

smuzaffar · 2025-11-12T09:59:10Z

@ftenchini can you please sign this too ?

ftenchini · 2025-11-12T10:46:24Z

+1
Sorry, I missed it...

makortel · 2025-11-24T20:40:45Z

The need for the X::Implementation request in the classes_def.xml to avoid header parsing was understood to be caused by the read rule referring to the X::Implementation (with X being the type alias passed to SET_PORTABLEHOSTMULTICOLLECTION_READ_RULES() macro). See #49399 (comment). Because of root-project/root#19705 its request must be in the classes_def.xml before the type that it aliases.

Why the omission of X::Implementation did not seem to trigger header parsing in ROOT 6.32 is not clear.

cmsbuild added this to the CMSSW_16_0_X milestone Nov 10, 2025

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending heterogeneous-pending tracking changes-dataformats labels Nov 10, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 10, 2025

cmsbuild added tests-started and removed tests-pending labels Nov 10, 2025

cmsbuild added tests-approved and removed tests-started labels Nov 10, 2025

smuzaffar mentioned this pull request Nov 11, 2025

[ROOT] Updated root to tip of branch master cms-sw/cmsdist#10187

Merged

cmsbuild added tests-started code-checks-pending labels Nov 11, 2025

cmsbuild added heterogeneous-approved and removed heterogeneous-pending labels Nov 11, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 11, 2025

cmsbuild added tests-approved and removed tests-started labels Nov 11, 2025

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Nov 12, 2025

cmsbuild added orp-approved and removed orp-pending labels Nov 12, 2025

cmsbuild merged commit dacb395 into cms-sw:master Nov 12, 2025
10 checks passed

Dr15Jones deleted the fixTracksHostImplementation branch November 14, 2025 15:32

makortel mentioned this pull request Nov 18, 2025

ROOT 6.36 results 510-660 MB higher memory usage in some workflows #49399

Closed

makortel mentioned this pull request Nov 25, 2025

[RFC] Improve PortableHost{Collection,Object} dictionary declarations #48824

Open

Need to add TracksHost::Implementation to classes_def.xml #49360

Need to add TracksHost::Implementation to classes_def.xml #49360

Uh oh!

Conversation

Dr15Jones commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

cmsbuild commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Nov 10, 2025

Uh oh!

cmsbuild commented Nov 10, 2025

Uh oh!

Dr15Jones commented Nov 10, 2025

Uh oh!

mmusich commented Nov 10, 2025

Uh oh!

Dr15Jones commented Nov 10, 2025

Uh oh!

makortel commented Nov 10, 2025

Uh oh!

mmusich commented Nov 10, 2025

Uh oh!

smuzaffar commented Nov 10, 2025

Uh oh!

smuzaffar commented Nov 10, 2025

Uh oh!

smuzaffar commented Nov 10, 2025

Uh oh!

cmsbuild commented Nov 10, 2025

Comparison Summary

Uh oh!

cmsbuild commented Nov 10, 2025

Comparison Summary

Uh oh!

cmsbuild commented Nov 10, 2025

Comparison Summary

Uh oh!

fwyzard commented Nov 11, 2025

Uh oh!

cmsbuild commented Nov 11, 2025

Uh oh!

cmsbuild commented Nov 11, 2025

Uh oh!

cmsbuild commented Nov 11, 2025

Comparison Summary

Uh oh!

smuzaffar commented Nov 11, 2025

Uh oh!

smuzaffar commented Nov 12, 2025

Uh oh!

jfernan2 commented Nov 12, 2025

Uh oh!

cmsbuild commented Nov 12, 2025

Uh oh!

smuzaffar commented Nov 12, 2025

Uh oh!

smuzaffar commented Nov 12, 2025

Uh oh!

ftenchini commented Nov 12, 2025

Uh oh!

Uh oh!

makortel commented Nov 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Dr15Jones commented Nov 10, 2025 •

edited

Loading

cmsbuild commented Nov 10, 2025 •

edited

Loading