[L1] [LLVM21] Apply clang-tidy changes #49497

smuzaffar · 2025-11-26T14:15:36Z

This PR suggests to apply the clang-tidy changes proposed by LLVM21 ( from CLANG_X IB).

cmsbuild · 2025-11-26T14:15:58Z

cms-bot internal usage

cmsbuild · 2025-11-26T14:22:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49497/46980

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/L1GlobalTrigger/src/L1GtfeExtWord.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File EventFilter/L1TRawToDigi/plugins/OmtfUnpacker.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockCounters.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockGEM.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockHeaders.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockME.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockRPC.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockSP.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File EventFilter/L1TRawToDigi/plugins/implementations_stage2/EMTFBlockTrailers.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File EventFilter/L1TRawToDigi/plugins/implementations_stage2/IntermediateMuonUnpacker.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File EventFilter/L1TRawToDigi/plugins/implementations_stage2/MuonUnpacker.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File EventFilter/L1TRawToDigi/plugins/implementations_stage2/RegionalMuonGMTUnpacker.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File EventFilter/L1TRawToDigi/src/AMC13Spec.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File L1Trigger/CSCTriggerPrimitives/src/CSCGEMMatcher.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File L1Trigger/DTTriggerPhase2/src/LateralityCoarsedProvider.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File L1Trigger/DTTriggerPhase2/src/MuonPathCorFitter.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File L1Trigger/DTTriggerPhase2/src/MuonPathSLFitter.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File L1Trigger/L1CaloTrigger/plugins/L1NNCaloTauEmulator.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File L1Trigger/L1TCaloLayer1/src/L1TCaloLayer1FetchLUTs.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File L1Trigger/L1TCalorimeter/src/HardwareSortingMethods.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File L1Trigger/L1TCalorimeter/src/PUSubtractionMethods.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File L1Trigger/L1TGEM/src/ME0StubAlgoPatUnit.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File L1Trigger/L1TGlobal/plugins/L1TGlobalPrescalesVetosESProducer.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File L1Trigger/L1TGlobal/plugins/L1TGlobalPrescalesVetosFractESProducer.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File L1Trigger/L1THGCal/plugins/backend/HGCalTowerProcessor.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File L1Trigger/L1THGCal/plugins/backend/HGCalTowerProcessor_SA.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File L1Trigger/L1TMuonOverlap/src/OMTFSorter.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File L1Trigger/L1TMuonOverlap/src/XMLConfigWriter.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File L1Trigger/L1TTrackMatch/plugins/L1TrackJetEmulatorProducer.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File L1Trigger/L1TTrackMatch/src/pTFrom2Stubs.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File L1Trigger/Phase2L1ParticleFlow/plugins/L1HPSPFTauProducer.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File L1Trigger/Phase2L1ParticleFlow/plugins/L1SeedConePFJetProducer.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File L1Trigger/Phase2L1ParticleFlow/src/pf/pfalgo2hgc_ref.cpp modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File L1Trigger/Phase2L1ParticleFlow/src/pf/pfalgo3_ref.cpp modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File L1Trigger/TrackFindingTMTT/src/HTrphi.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File L1Trigger/TrackFindingTMTT/src/KFParamsComb.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File L1Trigger/TrackFindingTMTT/src/KFbase.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File L1Trigger/TrackFindingTracklet/src/PurgeDuplicate.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File L1Trigger/TrackTrigger/src/TTStubAlgorithm_official.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297
- File L1Trigger/VertexFinder/src/VertexFinder.cc modified in PR(s): [L1T] Peak Finding Algorithm for Vertex Reconstruction (Phase 2) #47020, [Do not merge] LLVM21 clang-tidy changes #49297
- File L1TriggerConfig/L1TConfigProducers/src/L1TGlobalPrescalesVetosOnlineProd.cc modified in PR(s): [Do not merge] LLVM21 clang-tidy changes #49297

cmsbuild · 2025-11-26T14:22:24Z

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

DataFormats/L1GlobalTrigger (l1)
EventFilter/L1TRawToDigi (l1)
L1Trigger/CSCTriggerPrimitives (l1)
L1Trigger/DTTriggerPhase2 (l1)
L1Trigger/L1CaloTrigger (l1)
L1Trigger/L1TCaloLayer1 (l1)
L1Trigger/L1TCalorimeter (l1)
L1Trigger/L1TGEM (l1)
L1Trigger/L1TGlobal (l1)
L1Trigger/L1THGCal (l1)
L1Trigger/L1TMuonOverlap (l1)
L1Trigger/L1TTrackMatch (l1)
L1Trigger/Phase2L1ParticleFlow (l1)
L1Trigger/TrackFindingTMTT (l1)
L1Trigger/TrackFindingTracklet (l1)
L1Trigger/TrackTrigger (l1)
L1Trigger/VertexFinder (l1)
L1TriggerConfig/L1TConfigProducers (l1)

@BenjaminRS, @cmsbuild, @quinnanm can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @amarini, @battibass, @dinyar, @erikbutz, @eyigitba, @giovanni-mocellin, @jbsauvan, @lgray, @missirol, @mmusich, @ptcox, @rovere, @skinnari, @sviret, @thomreis, @valuev this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

quinnanm · 2025-11-26T14:40:48Z

please test

cmsbuild · 2025-11-26T17:15:43Z

-1

Failed Tests: UnitTests
Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ddf47/49695/summary.html
COMMIT: c0311c5
CMSSW: CMSSW_16_0_X_2025-11-26-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/49497/49695/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

You potentially added 5 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 2 differences found in the comparisons
Reco comparison had 4 failed jobs
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4269233
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4269213
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 198 edm output root files, 53 DQM output files
TriggerResults: no differences found

smuzaffar · 2025-12-06T13:44:44Z

please test

cmsbuild · 2025-12-06T15:37:18Z

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ddf47/49828/summary.html
COMMIT: c0311c5
CMSSW: CMSSW_16_0_X_2025-12-06-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49497/49828/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

You potentially removed 4 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
Reco comparison had 4 failed jobs
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4273241
DQMHistoTests: Total failures: 28
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4273193
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 198 edm output root files, 53 DQM output files
TriggerResults: no differences found

[L1] [LLVM21] Apply clang-tidy changes

c0311c5

cmsbuild added this to the CMSSW_16_0_X milestone Nov 26, 2025

cmsbuild added l1-pending pending-signatures tests-pending orp-pending code-checks-pending labels Nov 26, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 26, 2025

cmsbuild added tests-started and removed tests-pending labels Nov 26, 2025

cmsbuild added tests-rejected and removed tests-started labels Nov 26, 2025

cmsbuild added tests-started and removed tests-rejected labels Dec 6, 2025

cmsbuild added tests-approved and removed tests-started labels Dec 6, 2025

cmsbuild mentioned this pull request Dec 6, 2025

Delete obsolete TTTrack::stubPtConsistency function #49565

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[L1] [LLVM21] Apply clang-tidy changes #49497

[L1] [LLVM21] Apply clang-tidy changes #49497

Uh oh!

smuzaffar commented Nov 26, 2025

Uh oh!

cmsbuild commented Nov 26, 2025 •

edited

Loading

Uh oh!

cmsbuild commented Nov 26, 2025

Uh oh!

cmsbuild commented Nov 26, 2025

Uh oh!

quinnanm commented Nov 26, 2025

Uh oh!

cmsbuild commented Nov 26, 2025

Uh oh!

smuzaffar commented Dec 6, 2025

Uh oh!

cmsbuild commented Dec 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[L1] [LLVM21] Apply clang-tidy changes #49497

Are you sure you want to change the base?

[L1] [LLVM21] Apply clang-tidy changes #49497

Uh oh!

Conversation

smuzaffar commented Nov 26, 2025

Uh oh!

cmsbuild commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Nov 26, 2025

Uh oh!

cmsbuild commented Nov 26, 2025

Uh oh!

quinnanm commented Nov 26, 2025

Uh oh!

cmsbuild commented Nov 26, 2025

Failed Unit Tests

Comparison Summary

Uh oh!

smuzaffar commented Dec 6, 2025

Uh oh!

cmsbuild commented Dec 6, 2025

Comparison Summary

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cmsbuild commented Nov 26, 2025 •

edited

Loading