Skip to content

Remove cutTk condition from interpretationDescPSet#49680

Merged
cmsbuild merged 1 commit intocms-sw:masterfrom
mmusich:patch-1
Dec 21, 2025
Merged

Remove cutTk condition from interpretationDescPSet#49680
cmsbuild merged 1 commit intocms-sw:masterfrom
mmusich:patch-1

Conversation

@mmusich
Copy link
Contributor

@mmusich mmusich commented Dec 19, 2025

PR description:

Clean-up of unused configuration.
Spotted while reviewing #49652

PR validation:

runTheMatrix.py -l 34434.75,34434.752

runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

Remove cutTk condition for trackster selection.
@mmusich
Copy link
Contributor Author

mmusich commented Dec 19, 2025

test parameters:

  • workflows = ph2_hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 19, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49680/47242

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)
  • RecoHGCal/TICL (reconstruction)

@Martin-Grunewald, @Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @mmusich, @srimanob can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @apsallid, @denizsun, @felicepantaleo, @forthommel, @hatakeyamak, @lecriste, @missirol, @rovere, @salimcerci, @sameasy, @sobhatta this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Dec 19, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 48KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ac4a4/50362/summary.html
COMMIT: afd0623
CMSSW: CMSSW_16_1_X_2025-12-18-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49680/50362/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 71
  • DQMHistoTests: Total histograms compared: 4799218
  • DQMHistoTests: Total failures: 125
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4799073
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 70 files compared)
  • Checked 287 log files, 243 edm output root files, 71 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Dec 19, 2025

+hlt

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ded6308 into cms-sw:master Dec 21, 2025
11 checks passed
@mmusich mmusich deleted the patch-1 branch December 21, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants