Use std::range in FWCore/Framework by Dr15Jones · Pull Request #49841 · cms-sw/cmssw

Dr15Jones · 2026-01-14T20:10:33Z

PR description:

switched to std::ranges::iota for loops needing indicies
use std::view for case where makes simpler
Not a comprehensive change, just an experiment.

PR validation:

Purely technical change. Framework unit tests pass.

resolves cms-sw/framework-team#1788

cmsbuild · 2026-01-14T20:11:00Z

cms-bot internal usage

cmsbuild · 2026-01-14T20:12:22Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49841/47492

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49841/47492/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49841/47492/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2026-01-14T20:17:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49841/47493

cmsbuild · 2026-01-14T20:17:49Z

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

FWCore/Framework (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2026-01-14T20:17:55Z

please test

makortel · 2026-01-14T20:35:08Z

FWCore/Framework/src/EventProcessor.cc

        auto guard = makeGuard([this]() { actReg_->postPrincipalsCreationSignal_.emit(); });
        principalCache_.setNumberOfConcurrentPrincipals(preallocations_);
-        for (unsigned int index = 0; index < preallocations_.numberOfStreams(); ++index) {
+        for (auto index : std::views::iota(0UL, preallocations_.numberOfStreams())) {


numberOfStreams returns unsigned int, so how about

Suggested change

for (auto index : std::views::iota(0UL, preallocations_.numberOfStreams())) {

for (auto index : std::views::iota(0U, preallocations_.numberOfStreams())) {

?

makortel · 2026-01-14T20:40:30Z

FWCore/Framework/src/Schedule.cc

+        for (auto const& modLabel : tmp) {
+          modulesOnPaths.insert(modLabel);


Would

Suggested change

for (auto const& modLabel : tmp) {

modulesOnPaths.insert(modLabel);

modulesOnPaths.insert(std::ranges::begin(tmp), std::ranges::end(tmp));

work?

Doesn't compile. the types returned by std::ranges::begin and std::ranges::end do not identical.

- switched to std::ranges::iota for loops needing indicies - use std::view for case where makes simpler

cmsbuild · 2026-01-14T21:04:12Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49841/47495

cmsbuild · 2026-01-14T21:04:32Z

Pull request #49841 was updated. @Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please check and sign again.

Dr15Jones · 2026-01-14T21:26:35Z

please test

cmsbuild · 2026-01-14T23:19:47Z

+1

Size: This PR adds an extra 52KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf3657/50638/summary.html
COMMIT: b595bc7
CMSSW: CMSSW_16_1_X_2026-01-14-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49841/50638/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@makortel Temporarily disable X.999 workflow from the limited runTheMatrix #49805

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf3657/50638/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cf3657/50638/git-merge-result

Comparison Summary

Summary:

You potentially added 5 lines to the logs
Reco comparison results: 10 differences found in the comparisons
DQMHistoTests: Total files compared: 52
DQMHistoTests: Total histograms compared: 4025536
DQMHistoTests: Total failures: 12
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4025504
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
Checked 222 log files, 193 edm output root files, 52 DQM output files
TriggerResults: no differences found

makortel · 2026-01-15T14:30:08Z

+core

cmsbuild · 2026-01-15T14:30:29Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2026-01-15T19:18:44Z

+1

cmsbuild added this to the CMSSW_16_1_X milestone Jan 14, 2026

cmsbuild added core-pending pending-signatures tests-pending orp-pending code-checks-pending labels Jan 14, 2026

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jan 14, 2026

Dr15Jones force-pushed the rangesFramework branch from f50ab09 to f1ac576 Compare January 14, 2026 20:15

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jan 14, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 14, 2026

cmsbuild added tests-started and removed tests-pending labels Jan 14, 2026

makortel reviewed Jan 14, 2026

View reviewed changes

Use std::range in FWCore/Framework

b595bc7

- switched to std::ranges::iota for loops needing indicies - use std::view for case where makes simpler

Dr15Jones force-pushed the rangesFramework branch from f1ac576 to b595bc7 Compare January 14, 2026 21:01

cmsbuild added tests-pending code-checks-pending and removed tests-started code-checks-approved labels Jan 14, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 14, 2026

cmsbuild added tests-started and removed tests-pending labels Jan 14, 2026

cmsbuild added tests-approved and removed tests-started labels Jan 14, 2026

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Jan 15, 2026

cmsbuild added orp-approved and removed orp-pending labels Jan 15, 2026

cmsbuild merged commit 0fd6cf8 into cms-sw:master Jan 15, 2026
10 checks passed

Dr15Jones deleted the rangesFramework branch January 15, 2026 20:46

This was referenced Jan 16, 2026

Avoid test name clashes #49844

Merged

[ROOT639] Updated root to tip of branch master cms-sw/cmsdist#10274

Merged

	for (auto index : std::views::iota(0UL, preallocations_.numberOfStreams())) {
	for (auto index : std::views::iota(0U, preallocations_.numberOfStreams())) {

		for (auto const& modLabel : tmp) {
		modulesOnPaths.insert(modLabel);

	for (auto const& modLabel : tmp) {
	modulesOnPaths.insert(modLabel);
	modulesOnPaths.insert(std::ranges::begin(tmp), std::ranges::end(tmp));

Conversation

Dr15Jones commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

cmsbuild commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jan 14, 2026

Uh oh!

cmsbuild commented Jan 14, 2026

Uh oh!

cmsbuild commented Jan 14, 2026

Uh oh!

Dr15Jones commented Jan 14, 2026

Uh oh!

makortel Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

makortel Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Dr15Jones Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Jan 14, 2026

Uh oh!

cmsbuild commented Jan 14, 2026

Uh oh!

Dr15Jones commented Jan 14, 2026

Uh oh!

cmsbuild commented Jan 14, 2026

Comparison Summary

Uh oh!

makortel commented Jan 15, 2026

Uh oh!

cmsbuild commented Jan 15, 2026

Uh oh!

mandrenguyen commented Jan 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Dr15Jones commented Jan 14, 2026 •

edited

Loading

cmsbuild commented Jan 14, 2026 •

edited

Loading