Skip to content

Conversation

@jprendi
Copy link
Contributor

@jprendi jprendi commented Jan 26, 2026

Verbatim backport of #49938

PR description:

This PR accommodates for the changes in menu introduced through CMSHLT-3712 , renaming the path LocalTestDataScouting to streamDQMTestDataScouting. We also adapted the ngt client to include the beamspot and MetaDataDigis.

We also removed the onlyScouting condition everywhere as we now do save the online lumi metadata so it is no longer needed.

PR validation:

This PR was developed in CMSSW_16_0_X_2026-01-25-2300, using the packages DQM/Integration and DQM/HLTEvF.

We validated by creating streamer files in 398183 for the ngt-client and then running the following test:

cmsRun DQM/Integration/python/clients/ngt_dqm_sourceclient-live_cfg.py runInputDir=DQM-Integration runNumber=398183 scanOnce=True

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is the backport of #49938.


cc: @mmusich

@jprendi
Copy link
Contributor Author

jprendi commented Jan 26, 2026

type ngt

@cmsbuild
Copy link
Contributor

Pull request #49941 was updated.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 26, 2026

cms-bot internal usage

@jprendi jprendi changed the title Scouting dqm cmshlt 3712 backport Adapting changes from CMSHLT-3712 for Scouting DQM + removing onlyScouting condition [16_0_X] Jan 26, 2026
@jprendi jprendi marked this pull request as ready for review January 26, 2026 12:36
@mmusich
Copy link
Contributor

mmusich commented Jan 26, 2026

backport of #49938

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 26, 2026

A new Pull Request was created by @jprendi for CMSSW_16_0_X.

It involves the following packages:

  • DQM/HLTEvF (dqm, hlt)
  • DQM/Integration (dqm)

@Martin-Grunewald, @cmsbuild, @ctarricone, @gabrielmscampos, @mmusich, @nothingface0, @rseidita can you please review it and eventually sign? Thanks.
@batinkov, @francescobrivio, @missirol, @mmusich, @mtosi, @threus this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Jan 26, 2026

test parameters:

  • workflow = 145.415

@mmusich
Copy link
Contributor

mmusich commented Jan 26, 2026

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-897c2b/50897/summary.html
COMMIT: 6ab8e92
CMSSW: CMSSW_16_0_X_2026-01-26-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49941/50897/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 4213130
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4213104
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 53 files compared)
  • Checked 230 log files, 202 edm output root files, 54 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Jan 26, 2026

+hlt

@nothingface0
Copy link
Contributor

+dqm

@cmsbuild
Copy link
Contributor

Pull request #49941 was updated. @cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Jan 28, 2026

@mandrenguyen can you please unhold?

@mmusich
Copy link
Contributor

mmusich commented Jan 28, 2026

@cmsbuild, please test

@jprendi jprendi changed the title Adapting changes from CMSHLT-3712 for Scouting DQM + removing onlyScouting condition [16_0_X] Adapting changes from CMSHLT-3712 for Scouting DQM + + adapting the ngt dqm client [16_0_X] Jan 28, 2026
@jprendi jprendi changed the title Adapting changes from CMSHLT-3712 for Scouting DQM + + adapting the ngt dqm client [16_0_X] Adapting changes from CMSHLT-3712 for Scouting DQM + adapting the ngt dqm client [16_0_X] Jan 28, 2026
@jprendi jprendi changed the title Adapting changes from CMSHLT-3712 for Scouting DQM + adapting the ngt dqm client [16_0_X] Adapting changes from CMSHLT-3712 for the NGT DQM client [16_0_X] Jan 28, 2026
@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-897c2b/50959/summary.html
COMMIT: d8a4321
CMSSW: CMSSW_16_0_X_2026-01-27-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49941/50959/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 4213130
  • DQMHistoTests: Total failures: 114
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4212996
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 53 files compared)
  • Checked 230 log files, 202 edm output root files, 54 DQM output files
  • TriggerResults: no differences found

@nothingface0
Copy link
Contributor

+dqm

@mmusich
Copy link
Contributor

mmusich commented Jan 29, 2026

@mandrenguyen can you please unhold / merge?

@mandrenguyen
Copy link
Contributor

unhold

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_16_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_16_1_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 0dbf970 into cms-sw:CMSSW_16_0_X Jan 29, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants