Skip to content

Conversation

@goblirsc
Copy link
Contributor

@goblirsc goblirsc commented Jan 28, 2026

PR description:

This PR updates the CMSSW client code for interacting with Millepede2 and GBL to accomodate the latest updates to said packages.

  • new external package dependency for providing the Mille binary file interface.
  • removal of CMS-internal copy of Mille class.
  • removal of no-longer-needed gbl::MilleRecord instance in MillepedeAlignmentAlgorithm simultaneously talking to the same file as Mille instance (fragile).
  • py3-migrate a useful script found along the way.

Dependencies / expected changes / documentation:

  • this PR depends on an externals PR, cmsdist:#10310. Both should be tested together.
  • no changes to the output are expected. The alignment binaries written by the new Mille version are 1:1 compatible to the existing format.
  • Documentation of changes / new features: slides Alignment weekly 26.01.26).

PR validation:

  • unit tests (scram b runtests use-ibeos): passing
  • runTheMatrix.py -l limited -i all --ibeo: all tests passing except for few failures unrelated to the PR (missing datasets for e/gamma 136.X, DAS errors for 2022.00X-2025.00X)
  • alignment campaign with a local build of the modified CMSSW + externals: successful and identical output to existing codebase.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No backport needed

Before submitting your pull requests, make sure you followed this checklist:
✔️ verify that the PR is really intended for the chosen branch
✔️ verify that changes follow CMS Naming, Coding, And Style Rules
✔️ verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 28, 2026

cms-bot internal usage

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49963/47743

ERROR: Build errors found during clang-tidy run.

src/Alignment/MillePedeAlignmentAlgorithm/plugins/MillePedeAlignmentAlgorithm.cc:24:10: error: 'Mille/MilleFactory.h' file not found [clang-diagnostic-error]
   24 | #include "Mille/MilleFactory.h"                                     // external Mille library
      |          ^~~~~~~~~~~~~~~~~~~~~~
Suppressed 1082 warnings (1082 in non-user code).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

@goblirsc goblirsc marked this pull request as ready for review January 28, 2026 16:18
@smuzaffar
Copy link
Contributor

code-checks with cms.week0.PR_6e7d7ce1/100.0-e18971569e0e45b7e8c26c8607cf3bf8

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @goblirsc for master.

It involves the following packages:

  • Alignment/MillePedeAlignmentAlgorithm (alca)
  • Alignment/ReferenceTrajectories (alca)
  • PhysicsTools/PythonAnalysis (analysis)

@Alejandro1400, @JanChyczynski, @arunhep, @atpathak, @cmsbuild, @perrotta, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @rsreds, @tlampen, @tocheng, @yuanchao this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

test parameters:

@perrotta
Copy link
Contributor

please test

@@ -1581,17 +1595,11 @@ void MillePedeAlignmentAlgorithm::addLasBeam(const EventInfo &eventInfo,
const float residual = hit.localPosition().x() - tsoses[iHit].localPosition().x();
// error from file or assume 0.003
const float error = 0.003; // hit.localPositionError().xx(); sqrt???
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is beyond this PR, but I do wonder: is this really meant to be hardcoded at 0.003?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants