Fix: Intel Objectives TGUI Bluescreen when known objective is deleted #11457
+56
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmss13-ci
bot
added
Fix
Contributor
|
Code LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Resolves: #11452
By making sure the objective's state isn't OBJECTIVE_ACTIVE when it's deleted.
Still un-sure how these are getting deleted but it's happening apparently?
Force the recycler to spit them out, in case it's that.
Force the crematorium to spit them out, in case it's that as well.
Shuffle some stuff with the crematorium so it gets rid of bodybags and the body inside them
Move the cleanable straight to the tile so it doesn't moan that crematorium doesn't have cleanables var
Explain why it's good for the game
Blue screening a whole menu for one or two missing items is probably bad.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑 MistChristmas
fix: View Intel Objectives bluescreening, crematoriums now cremate the people in the bodybag not just the bodybag.
/:cl: