Fix build on Fedora 43: add missing <cstdint> include#877
Open
Chessing234 wants to merge 1 commit intocmu-db:masterfrom
Open
Fix build on Fedora 43: add missing <cstdint> include#877Chessing234 wants to merge 1 commit intocmu-db:masterfrom
Chessing234 wants to merge 1 commit intocmu-db:masterfrom
Conversation
Fixes cmu-db#856. On some platforms (e.g., Fedora 43 with recent GCC), <cstdint> is not transitively included, causing a build failure because uint64_t is not declared in string_util.h. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Chessing234
force-pushed
the
fix/issue-856-missing-cstdint
branch
from
3943b96 to
141c00a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#include <cstdint>tostring_util.hwhich usesuint64_tin theFormatSize()declaration<cstdint>is no longer transitively included, causing a build failureFixes #856.
Test plan
uint64_tis the only type from<cstdint>used in this header