Add missing #include <cstdint> in string_util.h#880
Open
Chessing234 wants to merge 1 commit intocmu-db:masterfrom
Open
Add missing #include <cstdint> in string_util.h#880Chessing234 wants to merge 1 commit intocmu-db:masterfrom
Chessing234 wants to merge 1 commit intocmu-db:masterfrom
Conversation
Fixes build failure on systems where uint64_t is not implicitly included (e.g., Fedora 43 with newer GCC). Fixes cmu-db#856 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#include <cstdint>tosrc/include/common/util/string_util.huint64_t(inFormatSize) without including<cstdint>, which causes build failures on systems where this type is not transitively included (e.g., Fedora 43 with GCC 15)Details
On most platforms,
uint64_thappens to be pulled in transitively through other standard headers, but this is not guaranteed by the C++ standard. Fedora 43 ships a newer GCC/libstdc++ that no longer transitively includes<cstdint>from<string>or<vector>, causing the build to fail with:The fix is a one-line addition of
#include <cstdint>alongside the existing includes.Fixes #856
🤖 Generated with Claude Code