Fix llvm version check in packages.sh#882
Open
Chessing234 wants to merge 2 commits intocmu-db:masterfrom
Open
Conversation
Fixes cmu-db#856. On newer GCC/Fedora 43, uint64_t is not implicitly included, causing build failures. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Use 'brew ls --versions llvm@${CLANG_VERSION}' instead of piping
through grep, which always failed to match because 'brew ls --versions
llvm' does not list versioned formulae like llvm@15.
Fixes cmu-db#805
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
brew ls --versionscheck for llvm inbuild_support/packages.sh(brew ls --versions llvm | grep ${CLANG_VERSION})always printed nothing becausebrew ls --versions llvmdoes not list versioned formulae likellvm@15brew ls --versions llvm@${CLANG_VERSION}which correctly checks whether the versioned formula is installedFixes #805
Test plan
build_support/packages.shon macOS with llvm@15 already installed — should detect it and skip installationbuild_support/packages.shon macOS without llvm@15 — should install it🤖 Generated with Claude Code