Add very basic CI #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lanlou1554
approved these changes
Nov 7, 2024
SarveshOO7
requested changes
Nov 8, 2024
Contributor
SarveshOO7
left a comment
SarveshOO7
left a comment
There was a problem hiding this comment.
LGTM! But we need to squash the commits before merging
This commit adds basic CI to this repository, where workflows are rooted in the `optd-persistent` directory. Everything here is mostly taken from https://github.com/jonhoo/rust-ci-conf with some major removals and modifications for things we don't need.
This commit fixes some of the bad minimal versions of the dependencies we take, as well as checks out the `Cargo.lock` file (this is supposed to be a library crate).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from https://github.com/jonhoo/rust-ci-conf and then modified
This PR also checks out the
Cargo.lockfile which I mistakenly ignored a few weeks ago. We want everyone working on this crate to be using the exact same dependencies.