fix: fix update_stats_from_catalog and improve the test #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xx01cyx
reviewed
Nov 9, 2024
lanlou1554
force-pushed
the
fix-update-stats-from-catalog
branch
2 times, most recently
from
31187b5 to
02407a5
Compare
xx01cyx
approved these changes
Nov 9, 2024
lanlou1554
force-pushed
the
fix-update-stats-from-catalog
branch
from
c5ee2c7 to
b900ee7
Compare
connortsui20
approved these changes
Nov 9, 2024
Member
connortsui20
left a comment
connortsui20
left a comment
There was a problem hiding this comment.
Ideally all global variables (statics and constants) should have comments on them, but other than that lgtm
Member
Done |
lanlou1554
force-pushed
the
fix-update-stats-from-catalog
branch
from
5e45159 to
b730d59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to insert into versioned_statistic and junction table when inserting stats from catalog :(
This PR fixes it.