Skip to content

feat(cost-model): Basic cost model computation #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 54 commits into from
Nov 19, 2024
Merged

feat(cost-model): Basic cost model computation #40

merged 54 commits into from
Nov 19, 2024

Conversation

@lanlou1554
Copy link
Contributor

@lanlou1554 lanlou1554 commented Nov 19, 2024

This PR implements basic cost model computation like agg, limit. It also implements initial unit test infra.

lanlou1554 and others added 30 commits November 16, 2024 11:25
@lanlou1554
Partial migration of filter
c92a3af
@lanlou1554
Change col to attr
7b0158c
@xx01cyx @lanlou1554
implement cost computation for limit
81f8d50
@xx01cyx @lanlou1554
add author
2a5740e
@xx01cyx @lanlou1554
introduce ColumnCombValueStats
f7f6857
@xx01cyx @lanlou1554
refactor AttributeCombValueStats and introduce statistic-related data…
be430ac 
… structures
@lanlou1554
Change col to attr in filter
089cfef
@lanlou1554
Complete partial implementation of filter
69607f1
@lanlou1554
Add get_attribute_comb_stats
6518e00
@lanlou1554
Finish first draft version of filter functionality
59a8889
@lanlou1554
Add comment for the guideline of re-designing PredicateNode
5070a78
@xx01cyx @lanlou1554
introduce IdPred and make AttributeRefPred store table id and attr index
740ab11
@xx01cyx @lanlou1554
add get method for id pred and add comments
85cd0d1
@xx01cyx @lanlou1554
add check for derived column in AttributeRefPred
7775b88
@xx01cyx @lanlou1554
make get_attributes_comb_statistics return Option
b60c632
@xx01cyx @lanlou1554
implement agg cost computation
3646eca
@xx01cyx @lanlou1554
move filter-related constants to stats crate
db555ff
@xx01cyx @lanlou1554
fix clippy
64f4a10
@lanlou1554
Resolve the optional comb stats, remove table id in filter
cafd01c
@lanlou1554
Refactor filter implementation
5c5a40f
@lanlou1554
Resolve conflict with main
dd6598a
@lanlou1554
Refactor cost model storage
03b6ec3
@lanlou1554
Move storage attribute to mod
a3b8088
@lanlou1554
Add initial test framework in cost_model.rs
c07b9fc
@lanlou1554
Fix typo in initial test framework
86f6fc2
@lanlou1554
Modify initial test framework
2c1f09b
@lanlou1554
Finish most tests for filter
ebab829
@lanlou1554
Finish all tests for filter
a8f92c3
@lanlou1554
Add important tricky todo
2c9240f
@lanlou1554
Improve filter tests
d6e1825
xx01cyx and others added 24 commits November 17, 2024 09:27
@xx01cyx
refine test infra
082f0be
@xx01cyx
add test for cost model agg
e183f02
@xx01cyx
make all data types u64 instead of usize
0059141
@xx01cyx
merge main and resolve conflicts
303d73c
@xx01cyx
copy paste join cardinality calculation
ec0afa6
@xx01cyx
make join compile
6d50843
@xx01cyx
rename col -> attr
a4ff526
@xx01cyx
refactor join to not pass in logical props
0ba4132
@xx01cyx
make statistics f64 instead of u64
ab15f05
@xx01cyx
split join into multiple files
b682c73
@xx01cyx
reorganize join
5d73141
@xx01cyx
refine test infra
51f917d
@xx01cyx
add test infra for join
5197090
@xx01cyx
refine mock interface
68b2885
@xx01cyx
make CostModelStorageManagerImpl::get_attribute_info unimplemented
36b93b9
@xx01cyx
modify MemoExt interface
11a3a4e
@xx01cyx
rename AttrRefPred -> AttrIndexPred and revert back to initial design
8c4191f
@lanlou1554
Modify the tests of filter and agg
1569fc5
@xx01cyx
add join test
489ff48
@xx01cyx
pass group id to join and fix filter-related tests
be71afb
@xx01cyx
fix all join tests
624d040
@lanlou1554
Change filter controller name
f8a0e70
@lanlou1554
Merge branch 'main' into cost-model-migration
11320dc
@lanlou1554
add basic cost computation
0f0b616
@lanlou1554 lanlou1554 requested a review from xx01cyx November 19, 2024 20:49
xx01cyx
xx01cyx approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@xx01cyx xx01cyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lanlou1554 lanlou1554 merged commit efd01f8 into main Nov 19, 2024
11 checks passed
@lanlou1554 lanlou1554 deleted the basic-cost-model-computation branch November 19, 2024 21:16
@lanlou1554 lanlou1554 mentioned this pull request Nov 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xx01cyx xx01cyx xx01cyx approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lanlou1554 @xx01cyx