Skip to content
This repository was archived by the owner on May 3, 2022. It is now read-only.

update bundle remove flag/help #697

Open
michelleN wants to merge 3 commits into
base: master
Choose a base branch
from
Open

update bundle remove flag/help #697

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3623392
update bundle remove flag/help
Apr 5, 2019
261f627
Merge branch 'master' into bundle-remove
jeremyrickard Jun 19, 2019
6cf9173
Merge branch 'master' into bundle-remove
jeremyrickard Aug 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/duffle/bundle_remove.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import (
const bundleRemoveDesc = `Remove a bundle from the local storage.

This removes a bundle from the local storage so that it will no longer be locally
available. Bundles can be rebuilt with 'duffle build'.
available. Bundles can be rebuilt and store in local storage with 'duffle build'.
Copy link
Contributor

@carolynvs carolynvs Apr 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: and stored in local storage


Ex. $ duffle bundle remove foo # removes all versions of foo from local store

Expand Down Expand Up @@ -46,7 +46,7 @@ func newBundleRemoveCmd(w io.Writer) *cobra.Command {
return remove.run()
},
}
cmd.Flags().StringVar(&remove.versions, "version", "", "A version or SemVer2 version range")
cmd.Flags().StringVarP(&remove.versions, "version", "r", "", "A version or SemVer2 version range")
Copy link
Contributor

@carolynvs carolynvs Apr 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the command should be duffle bundle rm mybundle -r version why -r as the shortcut for version?

Copy link
Member

@radu-matei radu-matei Apr 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose because -v is used for verbose output (at least it's supposed to be used that way, Simon pointed out that it's currently not working as intended).

Copy link
Member

@radu-matei radu-matei Apr 11, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the alternative would be not to have a shorthand flag at all?
(I'm happy with this approach, as -r is not really intuitive for passing a version).


return cmd
}
Expand Down