-
Notifications
You must be signed in to change notification settings - Fork 53
Conversation
|
@radu-matei I don't have access to the duffle-CI logs, so I don't know what is failling... |
|
@silvin-lubecki -- I was planning this as part of #681, but I don't really see any reason not to have this as a separate PR. I rescheduled the build, here's why it fails: Thanks! |
aba5726 to
0e70557
Compare
…kg/bundle. Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
0e70557 to
ab9588b
Compare
|
Just rebased and fixed the imports, thank you @radu-matei 👍 |
|
GitHub seems to be having some troubles today, both CIs are currently pending: |
|
Any particular reason why |
|
Well, the I think the less you have in the That said, I may be wrong and would be happy to add it to the |
radu-matei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks a lot for your contribution, I'll go ahead and rebase #681 on top of this work.
Vendor and use github.com/deislabs/cnab-go library, which extracted pkg/bundle.
Signed-off-by: Silvin Lubecki silvin.lubecki@docker.com