Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@

<ItemGroup>
<PackageReference Include="Mapster" Version="7.4.0" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="9.0.8" />
<PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="9.0.8" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="9.0.9" />
<PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="9.0.9" />
</ItemGroup>

</Project>
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
using Cnblogs.Architecture.Ddd.Infrastructure.Abstractions;

using Mapster;

namespace Cnblogs.Architecture.Ddd.Cqrs.Abstractions;
Expand All @@ -21,15 +20,21 @@ public async Task<PagedList<TView>> Handle(TQuery request, CancellationToken can
request.OrderByString,
out var orderBySegments);

var isNegativeIndexing = request.PagingParams?.PageIndex < 0;
if (isNegativeIndexing && orderBySegments is { Count: > 0 })
{
orderBySegments = orderBySegments.Select(o => o with { IsDesc = !o.IsDesc }).ToList();
}

var ordered = hasOrderBy && orderBySegments is { Count: > 0 }
? queryable.OrderBy(orderBySegments)
: DefaultOrderBy(request, queryable);
: DefaultOrderBy(request, queryable, isNegativeIndexing);

var totalCount = 0;
if (request.PagingParams != null)
{
totalCount = await CountAsync(request, queryable);
if (request.PagingParams.PageSize == 0 || totalCount == 0)
if (request.PagingParams.PageSize <= 0 || totalCount == 0)
{
// need count only or no available item, short circuit here.
return new PagedList<TView>([], request.PagingParams, totalCount);
Expand Down Expand Up @@ -60,6 +65,17 @@ public async Task<PagedList<TView>> Handle(TQuery request, CancellationToken can
/// <returns>Ordered <see cref="IQueryable{T}" />.</returns>
protected abstract IQueryable<TEntity> DefaultOrderBy(TQuery query, IQueryable<TEntity> queryable);

/// <summary>
/// The default reverse order by field, used when <see cref="OrderBySegment" /> is not present and pageIndex is negative.
/// </summary>
/// <param name="query">The query parameters.</param>
/// <param name="queryable"><see cref="IQueryable{TEntity}" /> returned by <see cref="Filter" />.</param>
/// <returns>Ordered <see cref="IQueryable{T}" />.</returns>
protected virtual IQueryable<TEntity> DefaultReverseOrderBy(TQuery query, IQueryable<TEntity> queryable)
{
return DefaultOrderBy(query, queryable);
}

/// <summary>
/// Create queryable and apply filter, return filtered <see cref="IQueryable{T}" />.
/// </summary>
Expand Down Expand Up @@ -95,4 +111,12 @@ protected virtual IQueryable<TView> ProjectToView(TQuery query, IQueryable<TEnti
/// <param name="queryable">Projected <see cref="IQueryable{T}" />.</param>
/// <returns>The query result.</returns>
protected abstract Task<List<TView>> ToListAsync(TQuery query, IQueryable<TView> queryable);

private IQueryable<TEntity> DefaultOrderBy(
TQuery query,
IQueryable<TEntity> queryable,
bool isNegativeIndexing)
{
return isNegativeIndexing ? DefaultReverseOrderBy(query, queryable) : DefaultOrderBy(query, queryable);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,17 +29,17 @@ public Task BindModelAsync(ModelBindingContext bindingContext)
}

var pageIndexSuccess = int.TryParse(pageIndexString, out var pageIndexNumber);
if (pageIndexSuccess == false || pageIndexNumber <= 0)
if (pageIndexSuccess == false)
{
bindingContext.ModelState.TryAddModelError(modelName, "PageIndex must be a positive number");
bindingContext.ModelState.TryAddModelError(modelName, "PageIndex must be a number");
bindingContext.Result = ModelBindingResult.Failed();
return Task.CompletedTask;
}

var pageSizeSuccess = int.TryParse(pageSizeString, out var pageSizeNumber);
if (pageSizeSuccess == false || pageSizeNumber < 0)
{
bindingContext.ModelState.TryAddModelError(modelName, "PageIndex must be a positive number or 0");
bindingContext.ModelState.TryAddModelError(modelName, "PageSize must be a positive number or 0");
bindingContext.Result = ModelBindingResult.Failed();
return Task.CompletedTask;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'net8.0'">
<PackageReference Include="Microsoft.Extensions.Http.Polly" Version="9.0.8" />
<PackageReference Include="Microsoft.Extensions.Http.Polly" Version="9.0.9" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'net9.0'">
<PackageReference Include="Microsoft.Extensions.Http.Polly" Version="9.0.8" />
<PackageReference Include="Microsoft.Extensions.Http.Polly" Version="9.0.9" />
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System.ComponentModel.DataAnnotations;
using System.ComponentModel.DataAnnotations;

using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Routing;
Expand All @@ -10,7 +10,7 @@ namespace Cnblogs.Architecture.Ddd.Infrastructure.Abstractions;
/// </summary>
/// <param name="PageIndex">页码。</param>
/// <param name="PageSize">每页元素数。</param>
public record PagingParams([Range(1, int.MaxValue)] int PageIndex, [Range(0, int.MaxValue)] int PageSize)
public record PagingParams(int PageIndex, [Range(0, int.MaxValue)] int PageSize)
{
/// <inheritdoc />
public override string ToString()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public static class QueryPager
public static IQueryable<T> Paging<T>(this IQueryable<T> queryable, PagingParams pagingParams)
{
var (pageIndex, pageSize) = pagingParams;
return queryable.Paging(pageIndex, pageSize);
return queryable.Paging(pageIndex < 0 ? -pageIndex : pageIndex, pageSize < 0 ? -pageSize : pageSize);
}

/// <summary>
Expand Down Expand Up @@ -53,4 +53,4 @@ public static IQueryable<T> Paging<T>(this IQueryable<T> queryable, int pageInde
? queryable.Take(pageSize)
: queryable.Skip((pageIndex - 1) * pageSize).Take(pageSize);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,15 @@ public QueryStringBuilder(
/// </summary>
/// <param name="pagingParams">分页参数。</param>
/// <returns></returns>
public QueryStringBuilder AddPaging(PagingParams pagingParams)
=> AddPaging(pagingParams.PageIndex, pagingParams.PageSize);
public QueryStringBuilder AddPaging(PagingParams? pagingParams)
=> AddPaging(pagingParams?.PageIndex, pagingParams?.PageSize);

/// <summary>
/// 添加分页参数。
/// </summary>
/// <param name="pageIndex">页码。</param>
/// <param name="pageSize">分页大小。</param>
public QueryStringBuilder AddPaging(int pageIndex, int pageSize)
public QueryStringBuilder AddPaging(int? pageIndex, int? pageSize)
=> Add(nameof(pageIndex), pageIndex).Add(nameof(pageSize), pageSize);

/// <summary>
Expand Down Expand Up @@ -170,4 +170,4 @@ public override string ToString()
{
return Build();
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<ItemGroup>
<ProjectReference Include="..\Cnblogs.Architecture.Ddd.Cqrs.DependencyInjection\Cnblogs.Architecture.Ddd.Cqrs.DependencyInjection.csproj"/>
<ProjectReference Include="..\Cnblogs.Architecture.Ddd.Infrastructure.Abstractions\Cnblogs.Architecture.Ddd.Infrastructure.Abstractions.csproj"/>
<PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="9.0.8" />
<PackageReference Include="Microsoft.Extensions.Caching.Memory" Version="9.0.9" />
</ItemGroup>

</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="StackExchange.Redis" Version="2.9.11" />
<PackageReference Include="StackExchange.Redis" Version="2.9.25" />
</ItemGroup>

</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

<ItemGroup>
<PackageReference Include="Dapper" Version="2.1.66" />
<PackageReference Include="Microsoft.Extensions.Options" Version="9.0.8" />
<PackageReference Include="Microsoft.Extensions.Options" Version="9.0.9" />
</ItemGroup>

</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="9.0.8" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="9.0.9" />
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="MongoDB.Driver" Version="3.4.3" />
<PackageReference Include="MongoDB.Driver" Version="3.5.0" />
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<ItemGroup>
<PackageReference Include="Cnblogs.Serilog.Extensions" Version="1.1.0" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.1.4">
<PackageReference Include="xunit.runner.visualstudio" Version="3.1.5">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
Expand All @@ -12,7 +12,7 @@
<PackageReference Include="Serilog.Sinks.InMemory" Version="2.0.0" />
<PackageReference Include="Serilog.AspNetCore" Version="9.0.0" />
<PackageReference Include="xunit" Version="2.9.3" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.0" />
</ItemGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ public async Task PagingParamsModelBinder_NoPageIndexOrPageSize_NullAsync(string

[Theory]
[InlineData("hello")]
[InlineData("-1")]
public async Task PagingParamsModelBinder_PageIndexInvalid_FailAsync(string pageIndex)
{
// Arrange
Expand Down
26 changes: 25 additions & 1 deletion test/Cnblogs.Architecture.TestShared/EntityGenerator.Varies.cs
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,15 @@ public EntityGenerator<TEntity> VaryByDateTimeDay(
days,
DateTime.Now);

public EntityGenerator<TEntity> VaryByDateTimeDay(
Expression<Func<TEntity, DateTimeOffset>>? datetimeAccess,
int days)
=> VaryByDateTime(
datetimeAccess,
(start, day) => start.AddDays(-day),
days,
DateTime.Now);

public EntityGenerator<TEntity> VaryByDateTime(
Expression<Func<TEntity, DateTime>>? datetimeAccess,
Func<DateTime, int, DateTime> timeDiffer,
Expand All @@ -59,6 +68,21 @@ public EntityGenerator<TEntity> VaryByDateTime(
return VaryBy(datetimeAccess, dates);
}

public EntityGenerator<TEntity> VaryByDateTime(
Expression<Func<TEntity, DateTimeOffset>>? datetimeAccess,
Func<DateTimeOffset, int, DateTimeOffset> timeDiffer,
int diffs,
DateTime startDate)
{
var dates = new DateTimeOffset[diffs];
for (var i = 0; i < diffs; i++)
{
dates[i] = timeDiffer(startDate, i);
}

return VaryBy(datetimeAccess, dates);
}

public EntityGenerator<TEntity> VaryByBoolean(Expression<Func<TEntity, bool>>? booleanAccess)
=> VaryBy(booleanAccess, true, false);

Expand All @@ -67,4 +91,4 @@ public EntityGenerator<TEntity> VaryByInt(Expression<Func<TEntity, int>>? intAcc

public EntityGenerator<TEntity> MultiplyBy(int times)
=> VaryBy<int>(null, Enumerable.Range(0, times));
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

<ItemGroup>
<PackageReference Include="xunit" Version="2.9.3"/>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1"/>
<PackageReference Include="xunit.runner.visualstudio" Version="3.1.4">
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.0" />
<PackageReference Include="xunit.runner.visualstudio" Version="3.1.5">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
namespace Cnblogs.Architecture.UnitTests.Cqrs.FakeObjects;

public record FakePostDto(int Id, DateTimeOffset DateAdded, DateTimeOffset DateUpdated);
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
using Cnblogs.Architecture.Ddd.Cqrs.Abstractions;
using Cnblogs.Architecture.Ddd.Infrastructure.Abstractions;

namespace Cnblogs.Architecture.UnitTests.Cqrs.FakeObjects;

public record TestPageableQuery(bool? Deleted, PagingParams? PagingParams, string? OrderByString)
: IPageableQuery<FakePostDto>;
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
using Cnblogs.Architecture.Ddd.Cqrs.EntityFramework;
using Cnblogs.Architecture.UnitTests.Infrastructure.FakeObjects;
using Microsoft.EntityFrameworkCore;

namespace Cnblogs.Architecture.UnitTests.Cqrs.FakeObjects;

public class TestPageableQueryHandler(DbContext context)
: EfPageableQueryHandler<TestPageableQuery, FakePost, FakePostDto>
{
/// <inheritdoc />
protected override IQueryable<FakePost> DefaultOrderBy(TestPageableQuery query, IQueryable<FakePost> queryable)
{
return queryable.OrderByDescending(x => x.DateAdded).ThenByDescending(x => x.DateUpdated);
}

/// <inheritdoc />
protected override IQueryable<FakePost> DefaultReverseOrderBy(TestPageableQuery query, IQueryable<FakePost> queryable)
{
return queryable.OrderBy(x => x.DateAdded).ThenBy(x => x.DateUpdated);
}

/// <inheritdoc />
protected override IQueryable<FakePost> Filter(TestPageableQuery query)
{
var queryable = context.Set<FakePost>().AsNoTracking();
if (query.Deleted.HasValue)
{
queryable = queryable.Where(x => x.Deleted == query.Deleted.Value);
}

return queryable;
}
}
Loading