cdi,SPECS.md: allow empty cgroup permissions. #301
+78
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/cc @oOraph |
Contributor
Author
Contributor
Author
|
@elezar PTAL, if you have a few spare cycles. |
elezar
previously requested changes
Jan 20, 2026
Contributor
elezar
left a comment
elezar
left a comment
There was a problem hiding this comment.
The addition of none as a special case looks good. I do think that the device validation needs to be properly updated for this though.
|
hello, thanks for this pull request. Since the cdi is generic it may still be worth adding the none case. I just want to mention some runc specificity regarding permissions that would make the none case ineffective for this runtime: |
klihub
force-pushed
the
devel/allow-empty-cgroup-permissions
branch
from
4d1f56c to
f8d98e4
Compare
Allow injecting devices with empty cgroup permissions, requested by the "none" permission string, also defined as pkg/cdi.NoPermissions. Signed-off-by: Krisztian Litkey <[email protected]>
klihub
force-pushed
the
devel/allow-empty-cgroup-permissions
branch
from
f8d98e4 to
df2a787
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow injecting devices with empty cgroup permissions, requested by the
"none"permission string or the newpkg/cdi.NoPermissionsconstant.Fixes #300