fix: correct duplicate detection logic in CNCFInsertKubestronautInPeoople_json.py…

[codeMaestro78]

CNCFInsertKubestronautInPeoople_json.py

Fixed two bugs:

1. Logic flaw: The loop broke on first iteration regardless of duplicate match, allowing duplicates to be inserted if they weren't first in the list.

2. Missing f-string prefix: '{newPeople.name}' was not being interpolated.

The duplicate check now iterates through ALL existing entries before inserting.

• What was happening before:

for people in data:
    if people["name"].lower() == newPeople.name.lower():
        exit(2)  # Only caught duplicate if it was the FIRST entry
    else:
        data.insert(0, ...)  # Inserted and broke immediately!
        break

• What happens now:

# Check ALL entries first
for people in data:
    if people["name"].lower() == newPeople.name.lower():
        print(f"{newPeople.name} already in people.json, abort!")
        exit(2)

# Only insert after confirming no duplicates
data.insert(0, ...)

#Bug

Logic flaw

• Before : Loop checked first person, then immediately broke (either adding or exiting)
• After : Loop iterates through ALL entries first to check for duplicates, only then inserts

f-string bug

• Before : print("{newPeople.name} already...") (literal string)
• after : print(f"{newPeople.name} already...") (interpolated)

[Copilot]

Pull request overview

This PR fixes two bugs in the duplicate detection logic for inserting Kubestronauts into people.json: (1) a logic flaw where the loop would break on the first iteration regardless of whether a duplicate was found, and (2) a missing f-string prefix that prevented name interpolation in the error message.

Key Changes:

• Separated duplicate checking from insertion logic - the loop now completes checking all entries before attempting to insert
• Added f-string prefix to the error message for proper name interpolation

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codeMaestro78]

Hi, @koksay
Can you please review this pr.

[koksay]

Hi @codeMaestro78 , sorry but I'm not the owner of this code. I believe CNCF folks are on vacation, you may not hear back until the new year.