Skip to content

Update Knative maintainers#1326

Merged
riaankleinhans merged 5 commits intocncf:mainfrom
creydr:add-knative-maintainers
Mar 17, 2026
Merged

Update Knative maintainers#1326
riaankleinhans merged 5 commits intocncf:mainfrom
creydr:add-knative-maintainers

Conversation

@creydr
Copy link
Copy Markdown
Contributor

@creydr creydr commented Mar 3, 2026

Checklist for maintainer updates

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 3, 2026

Deploy Preview for cncf-license-exceptions canceled.

Name Link
🔨 Latest commit 7be3da4
🔍 Latest deploy log https://app.netlify.com/projects/cncf-license-exceptions/deploys/69b832ea5433df0008a24323

Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
@creydr creydr force-pushed the add-knative-maintainers branch from d694bbf to 7735eed Compare March 3, 2026 16:24
Signed-off-by: Daniel Krook <krook@linux.com>
Signed-off-by: Daniel Krook <krook@linux.com>
@creydr
Copy link
Copy Markdown
Contributor Author

creydr commented Mar 9, 2026

Hello @krook,
is anything else from our side needed for this? Or is there a usual procedure for PRs like this?

@krook
Copy link
Copy Markdown
Member

krook commented Mar 9, 2026

Hello @krook, is anything else from our side needed for this? Or is there a usual procedure for PRs like this?

No, nothing additional needed. We just have a bit of a backlog processing these due to some team travel. Should be sorted soon.

@riaankleinhans
Copy link
Copy Markdown
Contributor

riaankleinhans commented Mar 13, 2026

@creydr looking a your PR.
Knative is already in the file:
https://github.com/cncf/foundation/blob/main/project-maintainers.csv?plain=1#L1271-L1289

Can you please consolidate the change to have only one list for the project? Thank you.

@creydr creydr changed the title Add Knative maintainers Update Knative maintainers Mar 13, 2026
@creydr
Copy link
Copy Markdown
Contributor Author

creydr commented Mar 13, 2026

@creydr looking a your PR. Knative is already in the file: https://github.com/cncf/foundation/blob/main/project-maintainers.csv?plain=1#L1271-L1289

Can you please consolidate the change to have only one list for the project? Thank you.

Oh no. Sorry, my bad I must have overseen it. I updated the list now

Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
@creydr creydr force-pushed the add-knative-maintainers branch from 704d090 to 8cdc46b Compare March 13, 2026 11:07
Signed-off-by: Riaan Kleinhans <61125752+riaankleinhans@users.noreply.github.com>
@riaankleinhans
Copy link
Copy Markdown
Contributor

@creydr there is miss match between this list and the project repo list.
Can you please update and match the lists.
https://github.com/knative/community/blob/main/MAINTAINERS.md

@creydr
Copy link
Copy Markdown
Contributor Author

creydr commented Mar 16, 2026

@creydr there is miss match between this list and the project repo list. Can you please update and match the lists. https://github.com/knative/community/blob/main/MAINTAINERS.md

@riaankleinhans do they need to match 1:1? Because I added in this PR here only the ones I know they are active (so this PR should be at least a subset of the ones from the Maintainers file)

@riaankleinhans
Copy link
Copy Markdown
Contributor

The idea is a one to one match. Based on the match we give maintainers access to CNCF service desk, maintainer mailing list, CNCF service desk, Github copilot etc.
Also important is that the CNCF maintainer summit is only open to verified maintainers.

@creydr
Copy link
Copy Markdown
Contributor Author

creydr commented Mar 16, 2026

Thanks for the quick response @riaankleinhans.

Also important is that the CNCF maintainer summit is only open to verified maintainers

That's the reason, why I am adding some maintainers (including myself) to this list

The idea is a one to one match. Based on the match we give maintainers access to CNCF service desk, maintainer mailing list, CNCF service desk, Github copilot etc.

My issue is that I can't speak for all of them. I thought the other could then add themself to the CNCF repo if they want. Should I then only create a PR to add the users without updating the link to the maintainers list?

@riaankleinhans riaankleinhans merged commit be743c4 into cncf:main Mar 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants