adds staff to model #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
RobertKielty
commented
Dec 17, 2025
RobertKielty
commented
- adds new DB entities Foundation and StaffMember so staff are stored separately from maintainers and linked to a foundation (CNCF or LF): model/main.go:134.
- Bootstrap now migrates and seeds staff data: - Auto-migrates Foundation + StaffMember: db/bootstrap.go:56 - Loads staff from Staff!A:F and associates each row with a Foundation: db/bootstrap.go:242 - Generalized readSheetRows to accept an explicit sheet range and configurable “carry-forward” columns: db/bootstrap.go:342
- Fixed a GORM migration bug by defining FoundationOfficer.Services as an explicit many-to-many relationship: model/main.go:203.
- Authorization updates for onboarding issue commands:
- Added SQLStore.IsStaffGitHubAccount to check if a GitHub login is a staff member: db/store_impl.go:195
- /label can be run by staff as well as maintainers: onboarding/ server.go:323 - /fossa-invite accepted can be run by staff as well as maintainers/ assignees (via a shared helper): onboarding/server.go:70, onboarding/server.go:137 - Tests updated/added to include staff models + verify staff authorization: onboarding/test_helpers.go:22, onboarding/ server_test.go:410
- adds new DB entities Foundation and StaffMember so staff are stored
separately from maintainers and linked to a foundation (CNCF or LF):
model/main.go:134.
- Bootstrap now migrates and seeds staff data:
- Auto-migrates Foundation + StaffMember: db/bootstrap.go:56
- Loads staff from Staff!A:F and associates each row with a
Foundation: db/bootstrap.go:242
- Generalized readSheetRows to accept an explicit sheet range and
configurable “carry-forward” columns: db/bootstrap.go:342
- Fixed a GORM migration bug by defining FoundationOfficer.Services as an
explicit many-to-many relationship: model/main.go:203.
- Authorization updates for onboarding issue commands:
- Added SQLStore.IsStaffGitHubAccount to check if a GitHub login is a
staff member: db/store_impl.go:195
- /label can be run by staff as well as maintainers: onboarding/
server.go:323
- /fossa-invite accepted can be run by staff as well as maintainers/
assignees (via a shared helper): onboarding/server.go:70,
onboarding/server.go:137
- Tests updated/added to include staff models + verify staff
authorization: onboarding/test_helpers.go:22, onboarding/
server_test.go:410
Signed-off-by: Robert Kielty <[email protected]>
- .golangci.yml:1 (remove run.skip-dirs, add exclusions for .modcache/.gocache) - cmd/sync/main.go:59 (handle errors from AddToScheme) Signed-off-by: Robert Kielty <[email protected]>
errors reported on make ci-local & PR Checks Tests / Lint(pull_request) Signed-off-by: Robert Kielty <[email protected]>
Added a new StaffMember API resource and wired it end‑to‑end. The API types now include StaffMember StaffMemberList plus spec/status and addKnownTypes registers it. The sync job now pulls staff from the DB and creates/updates StaffMember CRDs, using a new ListStaffMembers store method with Foundation preloaded. Generated artifacts were updated via make kcp-generate: a new CRD at config/crd/bases/maintainer-d.cncf.io_staffmembers.yaml, a new KCP schema at config/kcp/schema-staffmembers.yaml, and the APIExport plus other schema files were regenerated to include the new resource. Signed-off-by: Robert Kielty <[email protected]>
Signed-off-by: Robert Kielty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.