Open
Conversation
phlax
commented
Feb 24, 2026
| "@org_golang_google_protobuf//types/known/timestamppb:go_default_library", | ||
| "@org_golang_google_protobuf//types/known/wrapperspb:go_default_library", | ||
| "@protovalidate_go_gen//buf/validate", | ||
| ]).to_list(), |
Member
Author
There was a problem hiding this comment.
as an aside - this use of to_list looks very suspicious
phlax
force-pushed
the
protovalidate
branch
7 times, most recently
from
13c3fa7 to
2611c37
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc_proto_librarypgv is effectively deprecated and has very poor compatibility with bzlmod - so is no longer an option for Envoy
this upstreams a pending patch