Skip to content

Ch5xx spi st7735 demo#791

Open
unicab369 wants to merge 18 commits intocnlohr:masterfrom
unicab369:ch5xx_spi_st7735_demo
Open

Ch5xx spi st7735 demo#791
unicab369 wants to merge 18 commits intocnlohr:masterfrom
unicab369:ch5xx_spi_st7735_demo

Conversation

@unicab369
Copy link
Copy Markdown
Contributor

No description provided.

@cnlohr
Copy link
Copy Markdown
Owner

cnlohr commented Dec 3, 2025

@unicab369 please put the header files here into the folder of the demo. They're not ready for extralibs.

@cnlohr
Copy link
Copy Markdown
Owner

cnlohr commented Dec 3, 2025

Also, for all of them, even if not in common, please start using int or uint32_t etc... instead of u8 when int would do. It really makes the code more bloated and slower unnecessarily to use u8 or u16 unless you are actually doing something with arrays, etc. that are of the specific sizes.

@unicab369
Copy link
Copy Markdown
Contributor Author

@cnlohr I moved the files and make sure it built. I have to revisit this later to update the variable types and make sure it's still working.

@cnlohr
Copy link
Copy Markdown
Owner

cnlohr commented Jan 22, 2026

Sorry, I also realized a few things.

  1. I believe we already added a struct definition for the SPI for the CH5xx
  2. Please add documentation for where the font5x8 came from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants