CMake: allow use of system-provided meshlab & pybind11#445
CMake: allow use of system-provided meshlab & pybind11#445alemuntoni merged 4 commits intocnr-isti-vclab:develfrom
Conversation
|
@nim65s did you tested the pymeshlab package built and installed in an environment where meshlab was already installed? |
|
Yes, I did something like this: >>> from pymeshlab import MeshSet
>>> ms = MeshSet()
>>> ms.load_new_mesh("/…/base_link.STL")
>>> ms.meshing_decimation_quadric_edge_collapse()
>>> ms.save_current_mesh("/…/base_link2.STL")And base_link2.STL is created and lighter than the initial one. I did that with nixpkgs though, which add some additional magic to make certain things autowork and break others. I had to copy |
|
I tested that on linux and macos, with the following recipe: https://github.com/nim65s/nixpkgs/blob/meshlab/pkgs/applications/graphics/pymeshlab/default.nix |
|
Ok, that makes sense. I would just put a warning somewhere to say that the package would use meshlab built with single float precision, which could lead to different behaviors w.r.t. the pypi pymeshlab package (which uses double precision). Anyway, that's really great! Thanks for your work!! |
|
out of curiosity, what is the rationnale for the default single on meshlab but default double on pymeshlab ? |
|
On pymeshlab it is default double because it is default also in python. |
|
I've added a warning :) |
|
Thank you @nim65s!! :) |
follows cnr-isti-vclab/vcglib#248
NB: this PR is way easier to review by hidding whitespaces