Skip to content

Fix bugs in 3mf reader#1630

Merged
alemuntoni merged 2 commits intocnr-isti-vclab:mainfrom
lvk88:1610-forcetransform-bug
Dec 18, 2025
Merged

Fix bugs in 3mf reader#1630
alemuntoni merged 2 commits intocnr-isti-vclab:mainfrom
lvk88:1610-forcetransform-bug

Conversation

@lvk88
Copy link
Contributor

@lvk88 lvk88 commented Dec 17, 2025

This PR addresses various runtime and compiler bugs in the 3MF IO plugin:

  • 3MF import produces weird result when forcetransform is used #1610 : when meshlab is built with clang and loading a 3MF file such that Transform vertices instead of using transformation matrix is checked, the loaded objects were garbage, because of a missing zero initializer in the transformation matrix. This is now fixed
  • It was not possible to build meshlab with the 3mf plugin in debug mode with MSVC 19.5, because of signed-unsigned comparison warnings that are treated as errors. This is because lib3mf defines the treat-warnings-as-errors flag and W3 error level as a PUBLIC compile option, which then propagates to consumers of the target, such as the 3mf plugin. Wherever I could fix the warnings, I did, where I couldn't, I switched it off.
  • The runtime checks in MSVC's stdlib pointed out correctly that maskList was not resized to the correct size. This is also fixed
  • The option "Load colors and textures" was ignored by the 3MF implementation, and color + texture data was always loaded, regardless of what the user chose. This is also fixed now
  • The progress callback was not working properly because of an int-int division that should have been a double - int .

@alemuntoni
Copy link
Member

Thank you very much @lvk88!

@alemuntoni alemuntoni merged commit 1197485 into cnr-isti-vclab:main Dec 18, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants