fix: persist auth across browser windows using localStorage#557
Merged
fix: persist auth across browser windows using localStorage#557
Conversation
Switch JWT token storage from sessionStorage to localStorage so users stay signed in when opening new windows or tabs. Add cross-tab sync via the storage event so sign-in/out in one tab updates all others.
Update all E2E and accessibility tests to read/write the JWT token from localStorage instead of sessionStorage, matching the production code change.
- Fix try-flow.spec.ts to use localStorage for JWT token - Simplify cross-navigation persistence test to avoid Playwright quirk with /try page bundle initialization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sessionStoragetolocalStorageso users stay signed in when opening new browser windows or tabsstorageevent so sign-in/out in one tab automatically updates all other open tabssessionStoragesince these are correctly per-tabTest plan
src/try/authandsrc/try/api)