Skip to content

Conversation

@kruegercharles
Copy link
Collaborator

Ref-Issue: #392

@SoWieMarkus
Copy link
Collaborator

Hey Charly 👋

I noticed your test workflow is failing when trying to post the coverage comment. This happens because PRs from external contributors don't have write permissions to post comments (which is a GitHub security feature).

I've fixed this by adding continue-on-error: true to the comment steps, so the workflow will now succeed even if it can't post the comment. The tests will still run normally and you'll see the results in the workflow logs.

Just rebase on main to pick up the updated workflow.

@SoWieMarkus SoWieMarkus linked an issue Dec 12, 2025 that may be closed by this pull request
3 tasks
Comment on lines 247 to 248
// FIXME: is this correct?
return pod.Spec.SchedulerName == c.Conf.Operator
Copy link
Collaborator

@SoWieMarkus SoWieMarkus Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check it? For me, it looks good since you set the scheduler name to cortex-pods in the sample file, which matches the configured operator name :D So I think you can remove this comment.

Or is this FIXME related to Arno proposing just cortex as the scheduler name in #392 ?

Copy link
Collaborator Author

@kruegercharles kruegercharles Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I forget to remove the comment. I removed it now.

I also changed the scheduler name from cortex-pods to cortex to conform with Arno's proposal.

I've just tested it and the scheduler name gets set correctly for the test-pod.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure myself whether cortex alone makes sense here, or if cortex-pods would be more precise. However, in a Kubernetes context, cortex should be unique either way.

Did you receive a roadmap from Arno on how to proceed with this feature and its integration into Cortex?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not receive any additional information other than Arno's public issue #392 and the kanban boarder with the next TODOs: https://github.com/orgs/cobaltcore-dev/projects/19/views/1

Copy link
Member

@PhilippMatthes PhilippMatthes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!
Are the CRD definitions necessary? Please remove them.
Otherwise please just bump the dependency and we are good to go

@PhilippMatthes PhilippMatthes merged commit 458dd5a into cobaltcore-dev:main Dec 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop-in Kubernetes Scheduler

3 participants