Skip to content

Conversation

@fwiesel
Copy link
Contributor

@fwiesel fwiesel commented Dec 12, 2025

It reduces the api traffic, and also makes the code robust to schema changes.

It reduces the api traffic, and also makes the code robust to schema
changes.
@fwiesel fwiesel requested a review from notandy December 12, 2025 15:19
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/kvm-node-agent/internal/controller 21.38% (+0.40%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/kvm-node-agent/internal/controller/hypervisor_controller.go 33.33% (+0.72%) 93 (+1) 31 (+1) 62 👍
github.com/cobaltcore-dev/kvm-node-agent/internal/controller/secret_controller.go 0.00% (ø) 52 (+1) 0 52 (+1)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@notandy notandy merged commit 23bf1ca into main Dec 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants