HypervisorMaintenanceController: Enable/Disable compute service #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Draft, as it is missing other changes and conflicts with the existing code. |
fwiesel
force-pushed
the
hypervisor-maintenance
branch
from
1504dc1 to
3ba8b69
Compare
fwiesel
force-pushed
the
hypervisor-maintenance
branch
from
3ba8b69 to
4d6f80c
Compare
notandy
requested changes
Nov 14, 2025
Contributor
notandy
left a comment
notandy
left a comment
There was a problem hiding this comment.
lgtm apart from the EventFilter
notandy
reviewed
Nov 14, 2025
fwiesel
force-pushed
the
hypervisor-maintenance
branch
from
4d6f80c to
84f495c
Compare
The controller only gets active after onboarding, as that one needs to take care of enabling and aggregate association depending on the tests. If maintenance is set, it will disable now the compute host in nova, and enable it, if it is unset. It will only do so on an "edge", i.e. if it hasn't done it before.
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
notandy
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The controller only gets active after onboarding, as that one needs to take care of enabling and aggregate association depending on the tests.
If maintenance is set, it will disable now the compute host in nova, and enable it, if it is unset.
It will only do so on an "edge", i.e. if it hasn't done it before.