Skip to content

Extract service mock setup #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fwiesel merged 1 commit into from
Nov 17, 2025
Merged

Extract service mock setup #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 23 additions & 36 deletions internal/controller/hypervisor_maintenance_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,25 @@ var _ = Describe("HypervisorServiceController", func() {
}`
)

mockServiceUpdate := func(expectedBody string) {
// Mock services.Update
fakeServer.Mux.HandleFunc("PUT /os-services/1234", func(w http.ResponseWriter, r *http.Request) {
// parse request
Expect(r.Method).To(Equal("PUT"))
Expect(r.Header.Get("Content-Type")).To(Equal("application/json"))

// verify request body
body := make([]byte, r.ContentLength)
_, err := r.Body.Read(body)
Expect(err == nil || err.Error() == "EOF").To(BeTrue())
Expect(string(body)).To(MatchJSON(expectedBody))

w.WriteHeader(http.StatusOK)
_, err = fmt.Fprint(w, ServiceEnabledResponse)
Expect(err).NotTo(HaveOccurred())
})
}

// Setup and teardown
BeforeEach(func(ctx context.Context) {
By("Setting up the OpenStack http mock server")
Expand Down Expand Up @@ -115,24 +134,8 @@ var _ = Describe("HypervisorServiceController", func() {
Expect(tc.Client.Get(ctx, hypervisorName, hypervisor)).To(Succeed())
hypervisor.Spec.Maintenance = ""
Expect(tc.Client.Update(ctx, hypervisor)).To(Succeed())
// Mock services.Update
fakeServer.Mux.HandleFunc("PUT /os-services/1234", func(w http.ResponseWriter, r *http.Request) {
// parse request
Expect(r.Method).To(Equal("PUT"))
Expect(r.Header.Get("Content-Type")).To(Equal("application/json"))

// verify request body
expectedBody := `{"status": "enabled"}`
body := make([]byte, r.ContentLength)
_, err := r.Body.Read(body)
Expect(err == nil || err.Error() == "EOF").To(BeTrue())
Expect(string(body)).To(MatchJSON(expectedBody))

w.WriteHeader(http.StatusOK)
_, err = fmt.Fprint(w, ServiceEnabledResponse)
Expect(err).NotTo(HaveOccurred())
})

expectedBody := `{"status": "enabled"}`
mockServiceUpdate(expectedBody)
req := ctrl.Request{NamespacedName: hypervisorName}
_, err := tc.Reconcile(ctx, req)
Expect(err).NotTo(HaveOccurred())
Expand All @@ -153,24 +156,8 @@ var _ = Describe("HypervisorServiceController", func() {
Expect(tc.Client.Get(ctx, hypervisorName, hypervisor)).To(Succeed())
hypervisor.Spec.Maintenance = mode
Expect(tc.Client.Update(ctx, hypervisor)).To(Succeed())
// Mock services.Update
fakeServer.Mux.HandleFunc("PUT /os-services/1234", func(w http.ResponseWriter, r *http.Request) {
// parse request
Expect(r.Method).To(Equal("PUT"))
Expect(r.Header.Get("Content-Type")).To(Equal("application/json"))

// verify request body
expectedBody := fmt.Sprintf(`{"disabled_reason": "Hypervisor CRD: spec.maintenance=%v", "status": "disabled"}`, mode)
body := make([]byte, r.ContentLength)
_, err := r.Body.Read(body)
Expect(err == nil || err.Error() == "EOF").To(BeTrue())
Expect(string(body)).To(MatchJSON(expectedBody))

w.WriteHeader(http.StatusOK)
_, err = fmt.Fprint(w, ServiceEnabledResponse)
Expect(err).NotTo(HaveOccurred())
})

expectedBody := fmt.Sprintf(`{"disabled_reason": "Hypervisor CRD: spec.maintenance=%v", "status": "disabled"}`, mode)
mockServiceUpdate(expectedBody)
req := ctrl.Request{NamespacedName: hypervisorName}
_, err := tc.Reconcile(ctx, req)
Expect(err).NotTo(HaveOccurred())
Expand Down
Loading