Hypervisor maintenance controller test refactor #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix the name of the controller - tc is copy-pasta from traitscontroller, let's call it controller - HypervisorServiceController was only changed in code but not in the string - Use k8sClient in the tests directly instead of going through the controller - Move the reconciliation to JustBeforeEach, as we have always have to do that.
Merging this branch will increase overall coverage
Coverage by fileChanged unit test files
|
notandy
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional change, just renaming and restructuring of the tests.
tc(traits-controller) tocontrollerDeferCleanupfor cleanupJustBeforeEachfor reconciliation step.HypervisorServiceControllertoHypervisorMaintenanceControlleras that is the current name.