Skip to content

Conversation

@fwiesel
Copy link
Contributor

@fwiesel fwiesel commented Nov 18, 2025

This makes the source of the values clearer, as the show-managed-fields will show the controller sa field-owner.

@fwiesel fwiesel requested a review from notandy November 18, 2025 11:07
@fwiesel fwiesel changed the title Maintenance: Use SSA for declaring Resources GardenerNodeLifecycle: Use SSA for declaring Resources Nov 18, 2025
This makes the source of the values clearer, as the show-managed-fields
will show the controller sa field-owner.
@github-actions
Copy link

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller 38.25% (-0.39%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/gardener_node_lifecycle_controller.go 66.10% (-3.02%) 59 (-9) 39 (-8) 20 (-1) 👎
github.com/cobaltcore-dev/openstack-hypervisor-operator/internal/controller/utils.go 34.04% (+1.43%) 47 (+1) 16 (+1) 31 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@fwiesel fwiesel merged commit 1b57ee1 into main Nov 18, 2025
7 checks passed
@fwiesel fwiesel deleted the maintenance-ssa branch November 18, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants