Skip to content

test: Fix testCreateContainerValidation for real mouse clicks#2175

Draft
martinpitt wants to merge 6 commits intocockpit-project:mainfrom
martinpitt:mouse
Draft

test: Fix testCreateContainerValidation for real mouse clicks#2175
martinpitt wants to merge 6 commits intocockpit-project:mainfrom
martinpitt:mouse

Conversation

@martinpitt
Copy link
Member

Don't click too fast, wait until the "Add env" button click takes effect. Otherwise it ends up as a triple click on the button.

@martinpitt
Copy link
Member Author

martinpitt commented Jul 2, 2025

Are you effing kidding me? On 1081868 I ran that test 4x amplified (but only that test), and it all passed? (except for a boo-boo on firefox, which I fixed now). Trying once more, and then retrying with the full test suite -- apparently the background noise is significant?

Next run (with only that amplified test) was still perfect green with chromium, but bug on firefox - it seems the event handler doesn't bite? First checking if it is the scrolling.

@martinpitt martinpitt force-pushed the mouse branch 2 times, most recently from b9daa7b to 03a5ff6 Compare July 2, 2025 15:34
@martinpitt
Copy link
Member Author

martinpitt commented Jul 2, 2025

This debug-enabled run shows us that:

  • The "Create and run" button click was effective and the handler was called
  • The form validation failed as expected, but
  • the screenshot shows that the helper text does not actually appear (i.e. exactly what the test fails on)

I trigger another run with avoiding scrolling in this area as well -- it seems to have helped for firefox, although the test conditions are different (I need to re-run it with just the single amplified test).

Commit 03a5ff6 was full suite, amplified test, no scrolling. That significantly improved the results -- most testCreateContainerValidation passed, only f42/devel failed it twice -- and that was in the "remove invalid entries" section, when trying to delete the second button. The BiDi click happend, but the event handler wasn't called.

Commit 4d915ef was "only testCreateContainerValidation, amplified, no scrolling", which was perfectly green.

This is apparently related to system load then -- I locally tried to run four parallel tests, and still cannot reproduce it. While disabling scrolling helps, it's still not perfect.

Plan for tomorrow: Run the test manually in a bot, watch resource usage (/dev/shm etc.?).

Don't click too fast, wait until the "Add env" button click takes
effect. Otherwise it ends up as a triple click on the button.
martinpitt added a commit to martinpitt/cockpit-podman that referenced this pull request Jul 7, 2025
Doing the initial events with real clicks still caused the "Local"
button click to go into nirvana. This is being debugged in cockpit-project#2175, until
then avoid the flakes.
martinpitt added a commit to martinpitt/cockpit-podman that referenced this pull request Jul 7, 2025
The "Local button click goes to Nirvana in CI" happens with Firefox as
well. So upgrade the `chromium_fake_mouse` to "specify coordinates"
which activates fake clicks on all browsers.

This is being debugged in cockpit-project#2175, until then avoid the flakes.
martinpitt added a commit to martinpitt/cockpit-podman that referenced this pull request Jul 7, 2025
The "Local button click goes to Nirvana in CI" happens with Firefox as
well. So upgrade the `chromium_fake_mouse` to "specify coordinates"
which activates fake clicks on all browsers.

This is being debugged in cockpit-project#2175, until then avoid the flakes.
martinpitt added a commit that referenced this pull request Jul 8, 2025
The "Local button click goes to Nirvana in CI" happens with Firefox as
well. So upgrade the `chromium_fake_mouse` to "specify coordinates"
which activates fake clicks on all browsers.

This is being debugged in #2175, until then avoid the flakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant