workflows: Run browser integration tests#2439
Draft
martinpitt wants to merge 2 commits intocockpit-project:mainfrom
Draft
workflows: Run browser integration tests#2439martinpitt wants to merge 2 commits intocockpit-project:mainfrom
martinpitt wants to merge 2 commits intocockpit-project:mainfrom
Conversation
This is just a waste of resources.
This is just a proof of concept. It's missing image/npm/pixel git cache and posting to S3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just a proof of concept. It's missing image/npm/pixel git cache and posting to S3.
Moreover, this is slow. See this run on my fork. The "build package" is slow mostly because of the .qcow2 download (there is no caching). If we ever want to actually do that, we need a solution for an image cache for workflows.
But running the integration test (at two tests in parallel) takes 14 mins, whereas on our CI it takes 5. So this is really only an option for small projects, like starter-kit and cockpit-{files,podman}.