flatpak: Compose URL for screenshots mirror #22510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We started getting errors for our flatpak CI runs a few weeks ago. Which coincided with an upstream infrastructure issue which would explain the screenshots error. After infra was fixed and the fact that we didn't get any successful runs, something else was going on. Turns out that `flatpak-builder` had a release which changed the behaviour of `--compose-url-policy` to default to `partial` instead of `full` which was used before. Our fix is simple, just change it back to `full` Fixes: cockpit-project#22444 Related-to: flatpak/flatpak-builder#652 Signed-off-by: Freya Gustavsson <[email protected]>
Venefilyn
added
the
no-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We started getting errors for our flatpak CI runs a few weeks ago. Which
coincided with an upstream infrastructure issue which would explain the
screenshots error. After infra was fixed and the fact that we didn't get
any successful runs, something else was going on.
Turns out that
flatpak-builderhad a release which changed thebehaviour of
--compose-url-policyto default topartialinstead offullwhich was used before. Our fix is simple, just change it back tofullFixes: #22444
Related-to: flatpak/flatpak-builder#652
Signed-off-by: Freya Gustavsson [email protected]