lib: Override read-only inline input padding#22897
Conversation
Venefilyn
added
the
no-test
|
You can't trigger cockpit-files tests with these changes as we pin the cockpit lib commit. What you can do though is make a PR to cockpit-files with your commit ID or branch and then run the tests in cockpit-files. |
Venefilyn
force-pushed
the
lib/override-readonly-input
branch
from
9cd062b to
f928f37
Compare
PF6 read-only inline inputs has cropped border when it is focused/selected within a modal and positioned at the end of a modal body. Adding spacing to the modal body fixes the issue and makes the modal body look as it should. Related-to: patternfly/patternfly#8150 Signed-off-by: Freya Gustavsson <freya@venefilyn.se>
Venefilyn
removed
the
no-test
Venefilyn
force-pushed
the
lib/override-readonly-input
branch
from
f928f37 to
a8995d2
Compare
Will check pixel tests to see if anything breaks and needs to be fixed Do not merge Related-to: cockpit-project/cockpit#22897 Signed-off-by: Freya Gustavsson <freya@venefilyn.se>
Will check pixel tests to see if anything breaks and needs to be fixed Do not merge Related-to: cockpit-project/cockpit#22897 Signed-off-by: Freya Gustavsson <freya@venefilyn.se>
|
Still not happy with this solution. Too much changes and it kinda removes some of the structure from normal modals... I'll go back to just overriding the read-only padding for now I think |
Too much of a change. If we change to be for the input we need a selector. Even then it isn't super great In any case, I don't see the issue anywhere and as long as we don't have the input at the bottom of a modal we're fine. |
2 participants
PF6 read-only inline inputs has cropped border when it is
focused/selected within a modal and positioned at the end of a modal
body. Adding small spacing at the end fixes the issue.
Related-to: patternfly/patternfly#8150
Signed-off-by: Freya Gustavsson freya@venefilyn.se