cockpit: Work around Firefox bug re reloading iframes when navigating#22912
cockpit: Work around Firefox bug re reloading iframes when navigating#22912mvollmer merged 1 commit intocockpit-project:mainfrom
Conversation
| // See https://bugzilla.redhat.com/show_bug.cgi?id=2422331 | ||
| // | ||
| if (window.location.hash != hash) | ||
| if (navigator.userAgent.includes("Firefox")) { |
There was a problem hiding this comment.
This added line is not executed by any test. Details
| const a = document.createElement('a'); | ||
| a.href = hash; | ||
| document.body.appendChild(a); | ||
| a.click(); | ||
| document.body.removeChild(a); |
There was a problem hiding this comment.
These 5 added lines are not executed by any test. Details
|
The |
|
We should have a test that fails without this workaround... |
We have: At least TestMachinesCreate.testConfigureBeforeInstall fails with Firefiox 147, as expected. Our CI uses Firefox Nightly, which is currently 149, and which seems to have fixed that bug. (I was confused and thought 148 has it fixed.) |
|
So, since Firefox 149 has this fixed and will be released on March 24th, should we just sit this out? |
martinpitt
left a comment
martinpitt
left a comment
There was a problem hiding this comment.
Thanks! Indeed we won't get the workaroud into distros that much faster than March 21 (and especially not into RHEL), but if it does help somebody, this looks acceptable to me.
3 participants
No description provided.