polyfills: os.waitstatus_to_exitcode() for <3.9#22916
Merged
allisonkarlitskaya merged 1 commit intocockpit-project:mainfrom Feb 24, 2026
Merged
polyfills: os.waitstatus_to_exitcode() for <3.9#22916allisonkarlitskaya merged 1 commit intocockpit-project:mainfrom
allisonkarlitskaya merged 1 commit intocockpit-project:mainfrom
Conversation
Move the open-coded waitstatus_to_exitcode() logic from transports.py into polyfills.py as suggested by Martin. We adjust the code a little bit to match the actual stdlib implementation which means we have to catch ValueError at the call site. Closes cockpit-project#22915
allisonkarlitskaya
force-pushed
the
waitstatus_to_exitcode
branch
from
ad5430d to
d563216
Compare
allisonkarlitskaya
merged commit 0c10eca
into
cockpit-project:main
93 of 94 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the open-coded waitstatus_to_exitcode() logic from transports.py into polyfills.py as suggested by Martin.
Closes #22915