shell: More robust session time outs#22929
Open
mvollmer wants to merge 2 commits intocockpit-project:mainfrom
Open
shell: More robust session time outs#22929mvollmer wants to merge 2 commits intocockpit-project:mainfrom
mvollmer wants to merge 2 commits intocockpit-project:mainfrom
Conversation
Counting timer ticks works only when the ticks come on time. Usually they do, but browsers might decide to not run our JavaScript for whatever reason, especially if the tab is actually idle or minimized or otherwise hidden. By looking at the wall clock time, the session gets logged out immediately once the timer ticks start coming again (and it has indeed been idle long enough). See https://issues.redhat.com/browse/COCKPIT-1418
Member
Author
|
I will backport this to RHEL 8.10 once this is merged (and we agree that we should backport it). |
mvollmer
force-pushed
the
shell-real-time-idle-timeouts
branch
from
feb30a6 to
4ca92b7
Compare
and use it as a backup for the JavaScript session timeout implementation. With it, the session really ends at about the expected time, regardless of whether JavaScript is executed by the browser or not. We keep the JavaScript implementation so that session timeouts work with older cockpit-ws versions and to keep the cockpit-ws side simple. There anyway needs to be cooperation from JavaScript to perform a proper logout.
mvollmer
force-pushed
the
shell-real-time-idle-timeouts
branch
from
4ca92b7 to
b6b7ef0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes them work even when JavaScript stops running.
Demo: https://youtu.be/gVb_cbIlfqo